Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[archives/fast-element-1] fix(cherry-pick): close combobox even if no selection #6942

Conversation

chrisdholt
Copy link
Member

Pull Request

πŸ“– Description

Cherry pick of #6923 into the archives branch - thanks @zpeterson!

🎫 Issues

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

⏭ Next Steps

@chrisdholt chrisdholt changed the title Users/chhol/close combobox even if no selection [archives/fast-element-1] fix(cherry-pick): close combobox even if no selection Apr 24, 2024
@chrisdholt chrisdholt merged commit 9c6dbb6 into archives/fast-element-1 Apr 26, 2024
5 checks passed
@chrisdholt chrisdholt deleted the users/chhol/close-combobox-even-if-no-selection branch April 26, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants