fix(combobox): close the combobox even if there's no selection #6923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpeterson
requested review from
EisenbergEffect,
chrisdholt,
bheston,
scomea,
radium-v and
KingOfTac
as code owners
zpeterson
changed the title
scomea
requested changes
Mar 11, 2024
change/@microsoft-fast-foundation-47afe4a7-9451-4c4c-beba-70305e6b600e.json
Outdated
Show resolved
Hide resolved
packages/web-components/fast-foundation/src/combobox/combobox.ts
Outdated
Show resolved
Hide resolved
scomea
approved these changes
Mar 12, 2024
|
oh, i just noticed this as it tagged the issue i created. would be great if it got merged :) |
|
@bheston, @radium-v and @KingOfTac Please assess and approve this. We would like to get this fixed for .NET Aspire (with Fluent UI Blazor) so it needs to get cherry picked into |
radium-v
requested changes
Mar 16, 2024
packages/web-components/fast-foundation/src/combobox/combobox.ts
Outdated
Show resolved
Hide resolved
|
Is there any updates on this? is the change request of @radium-v still open? |
radium-v
force-pushed
the
users/zoepeterson/close-combobox-no-selection
branch
from
23fcbcf
to
ed5923b
Compare
radium-v
approved these changes
Mar 29, 2024
|
@KingOfTac , @chrisdholt , @EisenbergEffect : any updates on this? |
|
@scomea @KingOfTac any thoughts here? |
scomea
reviewed
Apr 9, 2024
packages/web-components/fast-foundation/src/combobox/combobox.ts
Outdated
Show resolved
Hide resolved
I smoked it, noticed a minor redundant line, but otherwise I'm good with merging. |
9 tasks
janechu
pushed a commit
that referenced
this pull request
Jun 10, 2024
* fix(combobox): close the combobox even if there's no selection * Change files * pr feedback * Bypass clicks on combobox input to allow indicator clicks (#1) * remove redundant line --------- Co-authored-by: John Kreitlow <863023+radium-v@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fix issue where the combobox remains open if there's no selection.
Before
After
🎫 Issues
#5721
microsoft/fluentui#30693
👩💻 Reviewer Notes
Test in Storybook and review the before/after GIFs.
📑 Test Plan
Tested in Storybook.
✅ Checklist
General
$ yarn changeComponent-specific