-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max item count in search options in SearchParameterDefinitionManager #2141
Conversation
@@ -275,7 +276,7 @@ private async Task LoadSearchParamsFromDataStore(CancellationToken cancellationT | |||
} | |||
} | |||
} | |||
while (continuationToken != null); | |||
while (continuationToken != null && !continuationToken.Contains("null", StringComparison.OrdinalIgnoreCase)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! That was not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Sets a value for MaxItemCount in searchOptions when searching for SearchParameter resources in SearchParameterDefinitionManager.
Downstream users of the searchOptions object expect a non-zero value to be populated in this field. When it was left at zero, a bug would be encountered which generated an invalid continuationToken causing searches to fail.
This manifested in the Stu3-CI-SQL environment, where the SearchParameterDefinitionManager would fail to initialize, then the searchParameterHash value would not be initialized, and then subsequent requests would fail with an error that the searchParameterHash was not specified for a stored procedure.
Related issues
Addresses [issue AB#84143].
Testing
Pointed my local environment at CI sql server, was able to repro the issue, made the fix and then the issue did not repro.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)
Skip