Set max item count in search options in SearchParameterDefinitionManager #2141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbans96
approved these changes
Aug 4, 2021
Ivanidzo4ka
reviewed
Aug 4, 2021
| @@ -275,7 +276,7 @@ private async Task LoadSearchParamsFromDataStore(CancellationToken cancellationT | |||
| } | |||
| } | |||
| } | |||
| while (continuationToken != null); | |||
| while (continuationToken != null && !continuationToken.Contains("null", StringComparison.OrdinalIgnoreCase)); | |||
There was a problem hiding this comment.
Oops! That was not necessary.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets a value for MaxItemCount in searchOptions when searching for SearchParameter resources in SearchParameterDefinitionManager.
Downstream users of the searchOptions object expect a non-zero value to be populated in this field. When it was left at zero, a bug would be encountered which generated an invalid continuationToken causing searches to fail.
This manifested in the Stu3-CI-SQL environment, where the SearchParameterDefinitionManager would fail to initialize, then the searchParameterHash value would not be initialized, and then subsequent requests would fail with an error that the searchParameterHash was not specified for a stored procedure.
Related issues
Addresses [issue AB#84143].
Testing
Pointed my local environment at CI sql server, was able to repro the issue, made the fix and then the issue did not repro.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)
Skip