Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better exception in case of bad expression in search parameter. #2157

Conversation

Ivanidzo4ka
Copy link
Contributor

@Ivanidzo4ka Ivanidzo4ka commented Aug 10, 2021

Description

Update OperationOutcome during search parameter creation if expression in search parameter is invalid

"issue": [
        {
            "severity": "error",
            "code": "exception",
            "diagnostics": "An error occurred creating the custom search parameter.  The issue must be resolved and the parameter resubmitted to become functional."
        },
        {
            "severity": "error",
            "code": "exception",
            "diagnostics": "Can't find 'CarePlan.activity.detail.extension.values' in type 'CarePlan'"
        }
    ]

Related issues

Addresses [#2146 ].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 50 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Dependencies, Enhancement, or New-Feature
  • Tag the PR with Azure API for FHIR if this will release to the managed service
  • Review squash-merge requirements

Semver Change (docs)

Patch

@Ivanidzo4ka Ivanidzo4ka requested a review from a team as a code owner August 10, 2021 22:30
@Ivanidzo4ka
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Ivanidzo4ka Ivanidzo4ka reopened this Aug 13, 2021
@Ivanidzo4ka Ivanidzo4ka merged commit 322b04d into microsoft:main Aug 13, 2021
@Ivanidzo4ka Ivanidzo4ka added this to the S69 milestone Aug 13, 2021
@Ivanidzo4ka Ivanidzo4ka added Enhancement Enhancement on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement Enhancement on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants