Fixes processing 429s from SPs #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotodd
approved these changes
Aug 12, 2021
Ivanidzo4ka
reviewed
Aug 12, 2021
| @@ -145,6 +145,6 @@ function acquireExportJobs(maximumNumberOfConcurrentJobsAllowedInString, jobHear | |||
| } | |||
|
|
|||
| function throwTooManyRequestsError() { | |||
| throw new Error(ErrorCodes.RequestEntityTooLarge, `The request could not be completed.`); | |||
| throw new Error(429, `The request could not be completed.`); | |||
There was a problem hiding this comment.
This const isn't in provided out of the box :( http://azure.github.io/azure-cosmosdb-js-server/DocDbWrapperScript.js.html
I could create our own, but it is still defined per proc
Ivanidzo4ka
reviewed
Aug 12, 2021
| @@ -24,6 +24,7 @@ function hardDelete(resourceTypeName, resourceId, keepCurrentVersion) { | |||
|
|
|||
| let deletedResourceIdList = new Array(); | |||
|
|
|||
| throwTooManyRequestsError(); | |||
There was a problem hiding this comment.
Thanks, that was my manual test :(
brendankowitz
force-pushed
the
personal/bkowitz/cosmos-sp-429s
branch
from
443ba96
to
60e6209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stored procedures return a statuscode 400 with a substatus when they fail. When this was a 429, we were not processing this correctly.
The errorcode in the SP was also not correct.
Related issues
Addresses [issue #].
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)