Fix history with PATCH in STU3 #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivanidzo4ka
added
Bug
| resource.FullUrlElement = new FhirUri(_urlResolver.ResolveResourceWrapperUrl(r.Resource, true)); | ||
| resource.Request = new Bundle.RequestComponent | ||
| if (hasVerb) |
There was a problem hiding this comment.
Should we throw an error if hasVerb is false, or will be it caught in the switch case below every time?
There was a problem hiding this comment.
Switch statement wouldn't throw exception because it's out parameter and it must be filled with something and for enums it's probably first thing in enum, which is Http.Get.
I'm reluctant to throw, since I'm not sure in which cases we don't have method, so I'll just put creation of response and request under if statement.
LTA-Thinking
approved these changes
Aug 24, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In STU3 PATCH doesn't exist in BundleVerb which leads to null ref because request is empty.
So substitute it to PUT.
Related issues
Addresses https://microsofthealth.visualstudio.com/Health/_workitems/edit/84461/
Testing
Manually and updated unit tests.
FHIR Team Checklist
Semver Change (docs)
Patch