This repository has been archived by the owner on Mar 4, 2020. It is now read-only.
feat(Image): add props interface #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzhelov
requested review from
dvdzkwsk,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 89.04% 89.04%
=======================================
Files 47 47
Lines 776 776
Branches 112 112
=======================================
Hits 691 691
Misses 83 83
Partials 2 2
Continue to review full report at Codecov.
|
mnajdova
reviewed
Aug 28, 2018
|
|
||
| export interface IImageProps { | ||
| accessibility?: Accessibility | ||
| as?: any |
There was a problem hiding this comment.
Oops, I was adding the accessibility prop as object | Function, as I didn't know that there is prop for this. We may need to update this in the other components
mnajdova
approved these changes
Aug 28, 2018
miroslavstastny
approved these changes
Aug 28, 2018
19 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces props interface for the Image component, as part of #117