Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fluent2 Tokens] Merge main to fluent2-tokens #1235

Merged
merged 9 commits into from
Sep 9, 2022
Merged

[Fluent2 Tokens] Merge main to fluent2-tokens #1235

merged 9 commits into from
Sep 9, 2022

Conversation

mischreiber
Copy link
Contributor

@mischreiber mischreiber commented Sep 9, 2022 •
edited by ghost
Loading

Platforms Impacted

  • iOS
  • macOS

Description of changes

Merging additional PRs from main to fluent2-tokens:

Verification

Sanity pass of affected components, mostly those already merged to main.

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

mischreiber and others added 9 commits September 7, 2022 14:08
@mischreiber
Move fluentTheme from window to view (microsoft#1219)
9344d17 
* Move `fluentTheme` from window to view

* Add logic to only refresh if view is a descendent of the newly themed view
@harrieshin
allow colorful image in notification toast
c5f5991 
Currently we always render the toast image as template. If the client team pass in image that is set "renderAsOriginal" respect that mode.
@harrieshin
add new module map in the fluentuilib and add copy phase (microsoft#1231
3e03bdc 
)

use FluentUI as a clang module in objc, we want to publish module.modulemap next to the fluentui-swift.h
@mischreiber
Removing spacing and padding values from token sets (microsoft#1220)
2759d39 
* First set of controls without spacing tokens

* Complete the rest of the controls

* Restoring in-use values

* Move layout constants to TokenSets
@jeaniehuynh
Revert Notification Colors to Fluent 1 Tokens (microsoft#1226)
27e38e2
@nodes11
CommandBar: Update group spacing and add large content viewer support (…
8d20d6a 
…microsoft#1229)

* Decrease CommandBar item group spacing to 8. Change received approval from the Fluent Design team.
* Enable LargeContentViewer for the CommandBar
@sophialee0416
Instantiating state variables in HUD (microsoft#1233)
3a41279
@huwilkes
Update AttributedText to scale (microsoft#1234)
10bf7a4
@mischreiber
Merge branch 'main' into mischreiber/fluent2-tokens-merge
85cdaf3
@mischreiber mischreiber requested a review from a team as a code owner September 9, 2022 23:14
@mischreiber mischreiber merged commit 5b7b214 into microsoft:fluent2-tokens Sep 9, 2022
@mischreiber mischreiber deleted the mischreiber/fluent2-tokens-merge branch September 10, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrieshin harrieshin harrieshin approved these changes

@huwilkes huwilkes huwilkes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mischreiber @harrieshin @huwilkes @jeaniehuynh @nodes11 @sophialee0416