Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent 2 iOS] Calendar & DateTimePicker updates #1278

Merged
merged 13 commits into from
Oct 3, 2022

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Sep 29, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

This PR addresses recent design changes to DateTimePicker and CalendarView.

  • CalendarViewDayCellBackgroundStyle which was removed in [Fluent 2 iOS] DateTimePicker + CalendarView update #1246 has been added back
  • dateIsTodayOrLater function has been changed to dateIsInCurrentMonth that returns whether the date is in the current month or not
  • Since design requested NOT to use elevated colors, we needed to specify the dark token inside the DynamicColor initializer for background colors
  • As part of the Move fluentTheme from window to view #1219 change, I added the checks for whether the view is a descendent of the changing view in themeDidChange functions

Verification

The changes were tested on the demo app.

Before After
after_calendar_light after_calendar_light
after_calendar_dark after_calendar_dark
after_calendar_segmented_light after_calendar_segmented_light
after_calendar_segmented_dark after_calendar_segmented_dark
after_date_time_light after_date_time_light
after_date_time_dark after_date_time_dark
after_date_time_segmented_light after_date_time_segmented_light
after_date_time_segmented_dark after_date_time_segmented_dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Sep 29, 2022
@laminesm laminesm requested a review from a team as a code owner September 29, 2022 21:40
@laminesm laminesm merged commit 34e469a into microsoft:fluent2-colors Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants