-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent 2 iOS] Calendar & DateTimePicker updates #1278
Merged
laminesm
merged 13 commits into
microsoft:fluent2-colors
from
laminesm:laminemale/calendar-fix
Oct 3, 2022
Merged
[Fluent 2 iOS] Calendar & DateTimePicker updates #1278
laminesm
merged 13 commits into
microsoft:fluent2-colors
from
laminesm:laminemale/calendar-fix
Oct 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophialee0416
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
This PR addresses recent design changes to
DateTimePicker
andCalendarView
.CalendarViewDayCellBackgroundStyle
which was removed in [Fluent 2 iOS] DateTimePicker + CalendarView update #1246 has been added backdateIsTodayOrLater
function has been changed todateIsInCurrentMonth
that returns whether the date is in the current month or notDynamicColor
initializer for background colorsfluentTheme
from window to view #1219 change, I added the checks for whether the view is a descendent of the changing view inthemeDidChange
functionsVerification
The changes were tested on the demo app.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow