Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluent 2 iOS] DateTimePicker + CalendarView update #1246

Merged

Conversation

laminesm
Copy link
Contributor

@laminesm laminesm commented Sep 14, 2022

Platforms Impacted

  • iOS
  • macOS

Description of changes

DateTimePicker and CalendarView have been updated to match their fluent 2 design.
The navigation bar for DateTimePicker is being set by FluentUIFramework. As of now, I have only added functionality to handle the custom nav bar specs for DateTimePicker. The entire class will be updated separately to use tokens instead of Colors in a separate PR.

Verification

All the changes were tested on the demo app.

Before After
before_calendar_light after_calendar_light
before_calendar_dark after_calendar_dark
before_calendar_segmented_light after_calendar_segmented_light
before_calendar_segmented_dark after_calendar_segmented_dark
before_calendar_subtitle_light after_calendar_subtitle_light
before_calendar_subtitle_dark after_calendar_subtitle_dark
before_date_time_light after_date_time_light
before_date_time_dark after_date_time_dark
before_date_time_segmented_light after_date_time_segmented_light
before_date_time_segmented_dark after_date_time_segmented_dark
before_light after_light
before_dark after_dark

Pull request checklist

This PR has considered:

  • Light and Dark appearances
  • iOS supported versions (all major versions greater than or equal current target deployment version)
  • VoiceOver and Keyboard Accessibility
  • Internationalization and Right to Left layouts
  • Different resolutions (1x, 2x, 3x)
  • Size classes and window sizes (iPhone vs iPad, notched devices, multitasking, different window sizes, etc)
  • iPad Pointer interaction
  • SwiftUI consumption (validation or new demo scenarios needed)
  • Objective-C exposure (provide it only if needed)
Microsoft Reviewers: Open in CodeFlow

@laminesm laminesm added the fluent2-colors 🎨 Changes targeting the fluent2-colors branch. label Sep 14, 2022
@laminesm laminesm requested a review from a team as a code owner September 14, 2022 16:13
@harrieshin
Copy link
Contributor

i understand you might be following the design spec, but it seems bit weird the the previous dates are darker and future dates are lighter? shouldn't selectable date be darker?

@harrieshin
Copy link
Contributor

please update readme doc on datetimepicker as well

@harrieshin
Copy link
Contributor

because there is font change, can you do a quick larger text test?

@laminesm
Copy link
Contributor Author

i understand you might be following the design spec, but it seems bit weird the the previous dates are darker and future dates are lighter? shouldn't selectable date be darker?

I agree, it seemed a bit odd but I just defaulted to implementing what design spec'ed. I'll reach out and see what they think.

@laminesm
Copy link
Contributor Author

because there is font change, can you do a quick larger text test?

The contrast ratio issue found is the same as the issue with the activity indicator. Design suggested we ignore this issue until the FG colors are revisited. I have created a design ticket to track the controls currently affected.

@laminesm laminesm merged commit 4ea08e8 into microsoft:fluent2-colors Sep 16, 2022
@laminesm laminesm deleted the laminemale/date-time-picker-update branch September 16, 2022 19:29
@laminesm laminesm restored the laminemale/date-time-picker-update branch September 16, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fluent2-colors 🎨 Changes targeting the fluent2-colors branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants