-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fluent 2 iOS] DateTimePicker + CalendarView update #1246
[Fluent 2 iOS] DateTimePicker + CalendarView update #1246
Conversation
i understand you might be following the design spec, but it seems bit weird the the previous dates are darker and future dates are lighter? shouldn't selectable date be darker? |
please update readme doc on datetimepicker as well |
because there is font change, can you do a quick larger text test? |
I agree, it seemed a bit odd but I just defaulted to implementing what design spec'ed. I'll reach out and see what they think. |
The contrast ratio issue found is the same as the issue with the activity indicator. Design suggested we ignore this issue until the FG colors are revisited. I have created a design ticket to track the controls currently affected. |
Platforms Impacted
Description of changes
DateTimePicker
andCalendarView
have been updated to match their fluent 2 design.The navigation bar for
DateTimePicker
is being set byFluentUIFramework
. As of now, I have only added functionality to handle the custom nav bar specs forDateTimePicker
. The entire class will be updated separately to use tokens instead ofColors
in a separate PR.Verification
All the changes were tested on the demo app.
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow