Change DemoListViewController cells to grouped style #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edjamesmsft
approved these changes
Nov 22, 2022
sophialee0416
added a commit
that referenced
this pull request
Dec 1, 2022
* Drop support for iOS 14 and remove availability checks (#1357) * Update FluentUI project * Update FluentUI xcconfig * Update FluentUI.Demo project * Update MicrosoftFluentUI.podspec * Clean up Button * Clean up CommandBarButton * Clean up CommandBarButtonGroupView * Clean up LargeContentViewerModifier * Clean up Drawer * Clean up NavigationBar * Clean up BadgeLabelButton * Clean up PillButton * Clean up PillButtonBar * Clean up SegmentedPillButton * Clean up SideTabBar * Clean up TabBarView * Clean up PillButton v2 * Clean up PillButton v3 * Revert "Update FluentUI project" This reverts commit 1c97631. * Update README.md * Update Package.swift * Make ShimmerLinesView inherit ShimmerView init (#1362) * Make ShimmerLinesView inherit ShimmerView init * move shimmer to fluent2 and add new api to demo * Bring fluent2-tokens Segmented Control to main (#1363) * Bring in fluent2-token control * Add token set to project * Update dependent controls * Add colored background for demo * Update demos * Update demo order * Fix whitespace error * Add demo to show notification bar from top (#1364) * Update PR Template to include binary change (#1368) * Fix PersonaListViewDemoController navigation bar transparency bug (#1372) * Change from DemoController to UIViewController * Revert "Change from DemoController to UIViewController" This reverts commit 3b3aeb0. * Fix bug * Remove retain cycles (#1374) * update xcode version to 14.1 for ci (#1371) (#1378) * Implement the Unread Dot for TabBar and SideTabBar (#1349) * Implementing the unread dot on TabBarView * Better naming for variables and events * Updating SideTabBar demo to show the unread dot * Pr feedback - reorganizing, renaming, better documentation * Updating variable names and locations to follow guidance * Added accessibility string for unread dot * Switching to using a badge label for the unread dot * Cleaning up commented out code * Simplifying logic, using a single view for both the badge and the unreadDot * PR cleanup * Add isViewLoaded check (#1379) * Revert "Drop support for iOS 14 and remove availability checks (#1357)" (#1383) * Revert "Drop support for iOS 14 and remove availability checks (#1357)" This reverts commit 4fad398. * Fix whitespace error * Defensive fixes for a UIViewPropertyAnimator crash (#1385) * Latest localized resource files from Touchdown Build (#1388) Co-authored-by: edjamesmsft <edjamesmsft@users.noreply.github.com> Co-authored-by: Harrie Shin <hyshin@microsoft.com> * Fix linting issue (#1393) * Latest localized resource files from Touchdown Build (#1391) Co-authored-by: markavitale <markavitale@users.noreply.github.com> Co-authored-by: Harrie Shin <hyshin@microsoft.com> * Update demo page cell style (#1389) * Fix bottom sheet host height change detection (#1396) * Latest localized resource files from Touchdown Build (#1400) Co-authored-by: markavitale <markavitale@users.noreply.github.com> * Latest localized resource files from Touchdown Build (#1401) Co-authored-by: markavitale <markavitale@users.noreply.github.com> * Fix PopupMenuItemCell's token sink to not overwrite custom colors (#1398) * Change TVC updateAppearance to internal * Fix PopupMenu token sink * Fix Segmented Control unread dot for icons (#1408) * Fix unread dot anchor logic * Update demo to have an unread icon Co-authored-by: huwilkes <67026548+huwilkes@users.noreply.github.com> Co-authored-by: Jeanie Huynh <31874971+jeaniehuynh@users.noreply.github.com> Co-authored-by: Lamine Male <106181067+laminesm@users.noreply.github.com> Co-authored-by: Mike Schreiber <mischreiber@microsoft.com> Co-authored-by: Harrie Shin <hyshin@microsoft.com> Co-authored-by: James Edwards <edjamesmsft@outlook.com> Co-authored-by: Lukas Capkovic <3610850+lcapkovic@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: edjamesmsft <edjamesmsft@users.noreply.github.com> Co-authored-by: markavitale <markavitale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
The
DemoListViewControllercells are now using the grouped style to stay consistent with theTableViewgrouped background color.Binary change:
Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow