Updating Segmented Control #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating Segmented Control to add support for having full screen equal width pill buttons, customizable colors with pill buttons, the primary and onBrand styles for pill buttons, and the ability to retrieve the view of a button at an index
harrieshin
reviewed
Feb 25, 2021
harrieshin
reviewed
Feb 25, 2021
harrieshin
reviewed
Feb 25, 2021
harrieshin
reviewed
Feb 25, 2021
harrieshin
reviewed
Feb 25, 2021
Simplified Switch Case statements by combining similar cases. Removed Calls to #available api. Removed unnecessary call to set cornerCurve on pill button.
|
can you also add darkmode images and ipad images in the description of the PR? you can use markdown for table to make it look more organized with screenshots |
harrieshin
reviewed
Feb 26, 2021
ios/FluentUI.Demo/FluentUI.Demo/Demos/SegmentedControlDemoController.swift
Show resolved
Hide resolved
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
harrieshin
reviewed
Feb 26, 2021
rdeassis
reviewed
Feb 27, 2021
ios/FluentUI.Demo/FluentUI.Demo/Demos/SegmentedControlDemoController.swift
Outdated
Show resolved
Hide resolved
Fixed some code style concerns along with making changes to the demo app to better present the controls on the proper background. Also fixed a safe area issue on nothced iPhones.
Some how dropped the changes I meant to commit last time. They're in this commit, along with changes to try and use the UIWindowScene screen
harrieshin
reviewed
Feb 27, 2021
ios/FluentUI.Demo/FluentUI.Demo/Demos/SegmentedControlDemoController.swift
Outdated
Show resolved
Hide resolved
Update struct properties to no longer be public
harrieshin
reviewed
Mar 1, 2021
harrieshin
approved these changes
Mar 1, 2021
Updated the demo app to center the equal width controls. Changed the name of getViewForButton(at index:) to segmentView(at index:)
rdeassis
reviewed
Mar 2, 2021
Fixed a broken layout constraint on the width/trailing constraints of the control and updated the subspecs to move segmented control to its own subspec that depends on pill button. Also moved the segmented control's source file to its own folder to properly remove it from the controls subspec.
The static lib build was failing in the date time picker because SegmentedControl.swift wasn't included in the FluentUILib target. Also removed an extra SegmentedControl.swift from the top of the project that didn't belong.
rdeassis
reviewed
Mar 2, 2021
| @@ -87,6 +88,13 @@ Pod::Spec.new do |s| | |||
| presenters_ios.dependency 'MicrosoftFluentUI/Controls_ios' | |||
| presenters_ios.source_files = ["ios/FluentUI/Presenters/**/*.{swift,h}"] | |||
| end | |||
|
|
|||
| s.subspec 'SegmentedControl_ios' do |segmentedcontrol_ios| | |||
| segmentedcontrol_ios.platform = :ios | |||
There was a problem hiding this comment.
@huwilkes can you fix the indentation here? We only use spaces instead of tabs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Updating Segmented Control to add support for having full screen equal width pill buttons, customizable colors with pill buttons, the primary and onBrand styles for pill buttons, and the ability to retrieve the view of a button at an index. Also updated the demo app to show the new styles with and without equal width
Verification
Pull request checklist
This PR has considered:
Microsoft Reviewers: Open in CodeFlow