Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Looping behaviour after update to 4.3.0 / FluentDesignTheme #1282

Closed
woha opened this issue Jan 9, 2024 · 7 comments · Fixed by #1288
Closed

fix: Looping behaviour after update to 4.3.0 / FluentDesignTheme #1282

woha opened this issue Jan 9, 2024 · 7 comments · Fixed by #1288
Labels
status:in-progress Work is in progress
Milestone

Comments

@woha
Copy link

woha commented Jan 9, 2024

I've updated to 4.3.0 and I'm having a strange behaviour now in my settings panel where the user can set the theme via the FluentDesignTheme component.

It looks like the color select list is populated in an endless loop:

2024-01-09_09-16-35

A sample repo is available here: https://github.com/woha/theme-demo

@vnbaaij
Copy link
Collaborator

vnbaaij commented Jan 9, 2024

There might be an issue with a cached script. Have you tried a full hard reload?

@woha
Copy link
Author

woha commented Jan 9, 2024

Yes.
And I've also deleted the local storage for the the settings.

Look what's happening to the local storage:

2024-01-09_09-47-35

@dvoituron
Copy link
Collaborator

Hi,
I downloaded and ran your code, but without this problem... Weird.

1282.mp4

@woha
Copy link
Author

woha commented Jan 9, 2024

It only starts after selecting another theme.
Could you please try switching theme from System to Light and Dark?

@dvoituron
Copy link
Collaborator

I get it... This problem also occurs on our demo site and seems to be due to the new "OfficeColor.Random".
We will update this and find a workaround as soon as possible.

@woha
Copy link
Author

woha commented Jan 9, 2024 via email

@vnbaaij vnbaaij added the status:in-progress Work is in progress label Jan 9, 2024
@vnbaaij vnbaaij added this to the v4.3.1 milestone Jan 10, 2024
@woha
Copy link
Author

woha commented Jan 15, 2024

@vnbaaij / @dvoituron Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:in-progress Work is in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants