Add FluentTester readme for ios #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding instructions for how to launch the FluentTester on iOS, following Saad's instructions after recent updates. Will update the main Fluent Tester readme to point to this page.
Saadnajmi
requested changes
Sep 18, 2020
|
macOS has essentially the same instructions, so it would be nice to also include that markdown with this one |
HeyImChris
suggested changes
Sep 18, 2020
tido64
reviewed
Sep 18, 2020
Addressed Chris and Saad's feedback
Saadnajmi
reviewed
Sep 18, 2020
apps/README.md
Outdated
Comment on lines
1
to
2
| `FluentUI Tester` is the test app that we use to test our FluentUI components during development. It uses the [react-native-test app](https://github.com/microsoft/react-native-test-app) under the covers, and loads the FluentUI bundle. | ||
|
|
There was a problem hiding this comment.
nit: loads the fluent-tester bundle, not FluentUI bundle
There was a problem hiding this comment.
Fixed in recent commit.
|
So is the intention now to keep the documentation for all the apps at apps/README.md instead of having platform specific ones? Or is that just for now while we are only adding iOS? |
Saadnajmi
approved these changes
Sep 18, 2020
|
I'm doing separate PRs for each platform. For example, here's the macOS one: #465 |
HeyImChris
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Adding instructions for how to launch the FluentTester on iOS, following Saad's instructions after recent updates. Will update the main Fluent Tester readme to point to this page.
Verification
Ran through the documentation as I was writing it.
Pull request checklist
This PR has considered (when applicable):