Revert cra-template workaround (#21550)

microsoft · Feb 3, 2022 · c5059e1 · c5059e1
1 parent de4f240
commit c5059e1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/change/@fluentui-cra-template-f19ad23e-0c38-418c-b102-834d12de9304.json b/change/@fluentui-cra-template-f19ad23e-0c38-418c-b102-834d12de9304.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Revert adding resolution for babel because bug is fixed",
+  "packageName": "@fluentui/cra-template",
+  "email": "elcraig@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/cra-template/template.json b/packages/cra-template/template.json
@@ -12,9 +12,6 @@
       "typescript": "^4.1.2",
       "web-vitals": "^1.0.1"
     },
-    "resolutions": {
-      "@babel/core": "7.16.12"
-    },
     "eslintConfig": {
       "extends": ["react-app", "react-app/jest"]
     }

diff --git a/packages/fluentui/projects-test/src/createReactApp.ts b/packages/fluentui/projects-test/src/createReactApp.ts
@@ -30,14 +30,6 @@ export async function createReactApp() {
 
   await prepareCreateReactApp(tempPaths, 'typescript');
   const testAppPath = config.paths.withRootAt(tempPaths.testApp);
-
-  // TODO: remove once babel issue is fixed (tracked by https://github.com/microsoft/fluentui/issues/21546)
-  logger('Add resolution to work around @babel/core issue');
-  const packageJson = fs.readJSONSync(testAppPath('package.json'));
-  packageJson.resolutions = { '@babel/core': '7.16.12' };
-  fs.writeJSONSync(testAppPath('package.json'), packageJson, { spaces: 2 });
-  await shEcho('yarn', testAppPath());
-
   logger(`Test React project is successfully created: ${testAppPath()}`);
 
   logger('STEP 2. Add Fluent UI dependency to test project..');