-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert cra-template workaround #21550
Revert cra-template workaround #21550
Conversation
…ound bug (microsoft#21545)" This reverts commit 946f57c.
@@ -1,6 +1,6 @@ | |||
{ | |||
"type": "patch", | |||
"comment": "Temporarily add resolution for `@babel/core` to work around bug", | |||
"comment": "Revert adding resolution for babel because bug is fixed", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, this is appearing as a rename because it's deleting the old change file and adding a new one. If this goes in before the publish build, the change type here can be changed to none
.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 03ed517:
|
📊 Bundle size report🤖 This report was generated against 946f57cad4378ec779605d466ef1df3dd88ebc78 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 946f57cad4378ec779605d466ef1df3dd88ebc78 (build) |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
ContextualMenu | mount | 8497 | 17254 | 1000 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 907 | 961 | 5000 | |
BaseButton | mount | 951 | 916 | 5000 | |
Breadcrumb | mount | 2737 | 2631 | 1000 | |
ButtonNext | mount | 523 | 547 | 5000 | |
Checkbox | mount | 1610 | 1570 | 5000 | |
CheckboxBase | mount | 1345 | 1351 | 5000 | |
ChoiceGroup | mount | 4849 | 4894 | 5000 | |
ComboBox | mount | 985 | 1037 | 1000 | |
CommandBar | mount | 10435 | 10563 | 1000 | |
ContextualMenu | mount | 8497 | 17254 | 1000 | Possible regression |
DefaultButton | mount | 1182 | 1188 | 5000 | |
DetailsRow | mount | 3877 | 3769 | 5000 | |
DetailsRowFast | mount | 3825 | 3835 | 5000 | |
DetailsRowNoStyles | mount | 3580 | 3600 | 5000 | |
Dialog | mount | 2625 | 2665 | 1000 | |
DocumentCardTitle | mount | 184 | 197 | 1000 | |
Dropdown | mount | 3289 | 3264 | 5000 | |
FluentProviderNext | mount | 1945 | 1947 | 5000 | |
FluentProviderWithTheme | mount | 169 | 172 | 10 | |
FluentProviderWithTheme | virtual-rerender | 118 | 120 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 206 | 195 | 10 | |
FocusTrapZone | mount | 1901 | 1815 | 5000 | |
FocusZone | mount | 1848 | 1872 | 5000 | |
IconButton | mount | 1790 | 1784 | 5000 | |
Label | mount | 382 | 388 | 5000 | |
Layer | mount | 3033 | 2977 | 5000 | |
Link | mount | 516 | 516 | 5000 | |
MakeStyles | mount | 1750 | 1714 | 50000 | |
MenuButton | mount | 1535 | 1513 | 5000 | |
MessageBar | mount | 2071 | 2030 | 5000 | |
Nav | mount | 3370 | 3339 | 1000 | |
OverflowSet | mount | 1172 | 1177 | 5000 | |
Panel | mount | 2526 | 2531 | 1000 | |
Persona | mount | 893 | 916 | 1000 | |
Pivot | mount | 1507 | 1484 | 1000 | |
PrimaryButton | mount | 1316 | 1372 | 5000 | |
Rating | mount | 7832 | 7992 | 5000 | |
SearchBox | mount | 1390 | 1397 | 5000 | |
Shimmer | mount | 2634 | 2672 | 5000 | |
Slider | mount | 2007 | 2024 | 5000 | |
SpinButton | mount | 5145 | 5130 | 5000 | |
Spinner | mount | 472 | 449 | 5000 | |
SplitButton | mount | 3358 | 3272 | 5000 | |
Stack | mount | 587 | 566 | 5000 | |
StackWithIntrinsicChildren | mount | 2370 | 2359 | 5000 | |
StackWithTextChildren | mount | 5378 | 5454 | 5000 | |
SwatchColorPicker | mount | 11804 | 11698 | 5000 | |
TagPicker | mount | 2657 | 2678 | 5000 | |
TeachingBubble | mount | 13531 | 13477 | 5000 | |
Text | mount | 486 | 467 | 5000 | |
TextField | mount | 1470 | 1455 | 5000 | |
ThemeProvider | mount | 1231 | 1284 | 5000 | |
ThemeProvider | virtual-rerender | 659 | 641 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1949 | 1964 | 5000 | |
Toggle | mount | 831 | 840 | 5000 | |
buttonNative | mount | 164 | 167 | 5000 |
Current Behavior
#21545 added a workaround for an issue causing our tests that use create-react-app to fail. (see old PR description for details)
New Behavior
Issue is fixed per facebook/create-react-app#12017 (comment) / babel/babel#14229 (comment). Revert workaround.
Fixes #21546