Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to remove outdated patterns in components inside of @react-button package #18379

Closed
khmakoto opened this issue May 29, 2021 · 2 comments · Fixed by #18519
Closed

Need to remove outdated patterns in components inside of @react-button package #18379

khmakoto opened this issue May 29, 2021 · 2 comments · Fixed by #18519
Assignees
@khmakoto
Labels
Component: Button Component: CompoundButton Component: MenuButton Component: SpinButton Component: ToggleButton Status: Fixed Fixed in some PR
Projects
CXE Redmond - @microsoft/cxe-red
Milestone
June Project Cycl...

Comments

@khmakoto
Copy link
Member

There are a couple of patterns that were introduced in the @fluentui/react-button package when we first did an alpha released that are now outdated and should be removed. This is an issue to track that work item.

Related to #16746, #18135 and #18136.
@khmakoto khmakoto self-assigned this May 29, 2021
@khmakoto khmakoto added this to To do in CXE Redmond - @microsoft/cxe-red via automation May 29, 2021
@khmakoto khmakoto mentioned this issue May 29, 2021
Merged
2 tasks
@khmakoto
Copy link
Member Author

khmakoto commented Jun 7, 2021

This is expected to be done in June.

@khmakoto khmakoto added this to the June Project Cycle Q2 2021 milestone Jun 7, 2021
@khmakoto khmakoto moved this from To do to In progress in CXE Redmond - @microsoft/cxe-red Jun 7, 2021
@khmakoto khmakoto mentioned this issue Jun 7, 2021
Merged
2 tasks
msft-fluent-ui-bot pushed a commit that referenced this issue Jun 9, 2021
@khmakoto
Button: Removing legacy patterns from converged component (#18468)
aa5faf9 
#### Pull request checklist

- [x] Addresses an existing issue: Fixes part of #17555 and #18379
- [x] Include a change request file using `$ yarn change`

#### Description of changes

This PR removes most of the legacy patterns that were being used in the `Button` component in `@fluentui/react-button`, instead opting for using the patterns adopted by other converged components such as `Avatar` in `@fluentui/react-avatar`.

PRs to update `CompoundButton`, `MenuButton` and `ToggleButton` will follow.
This was referenced Jun 9, 2021
Merged
Merged
Merged
Merged
CXE Redmond - @microsoft/cxe-red automation moved this from In progress to Done Jun 22, 2021
@msft-fluent-ui-bot msft-fluent-ui-bot added Status: Fixed Fixed in some PR and removed Status: In PR labels Jun 22, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉This issue was addressed in #18519, which has now been successfully released as @fluentui/react-button@v9.0.0-alpha.50.:tada:

Handy links:

@microsoft microsoft locked as resolved and limited conversation to collaborators Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@khmakoto khmakoto

Labels
Component: Button Component: CompoundButton Component: MenuButton Component: SpinButton Component: ToggleButton Status: Fixed Fixed in some PR
Projects
No open projects
CXE Redmond - @microsoft/cxe-red
Done
Milestone
June Project Cycle Q2 2021
Development

Successfully merging a pull request may close this issue.

react-button: Removing last remnants of legacy patterns khmakoto/fluentui
2 participants
@khmakoto @msft-fluent-ui-bot