ToggleButton: Removing legacy patterns from converged component. #18506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 3a08bcacbd059fbc1d528607639576c4512433c7 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 789 | 806 | 5000 | |
| BaseButton | mount | 894 | 891 | 5000 | |
| Breadcrumb | mount | 2581 | 2571 | 1000 | |
| ButtonNext | mount | 523 | 502 | 5000 | |
| Checkbox | mount | 1490 | 1493 | 5000 | |
| CheckboxBase | mount | 1263 | 1254 | 5000 | |
| ChoiceGroup | mount | 4626 | 4648 | 5000 | |
| ComboBox | mount | 958 | 945 | 1000 | |
| CommandBar | mount | 9923 | 9961 | 1000 | |
| ContextualMenu | mount | 5997 | 5997 | 1000 | |
| DefaultButton | mount | 1115 | 1079 | 5000 | |
| DetailsRow | mount | 3652 | 3718 | 5000 | |
| DetailsRowFast | mount | 3677 | 3742 | 5000 | |
| DetailsRowNoStyles | mount | 3462 | 3489 | 5000 | |
| Dialog | mount | 2098 | 2147 | 1000 | |
| DocumentCardTitle | mount | 147 | 140 | 1000 | |
| Dropdown | mount | 3183 | 3183 | 5000 | |
| FocusTrapZone | mount | 1710 | 1750 | 5000 | |
| FocusZone | mount | 1793 | 1774 | 5000 | |
| IconButton | mount | 1711 | 1689 | 5000 | |
| Label | mount | 332 | 326 | 5000 | |
| Layer | mount | 1782 | 1767 | 5000 | |
| Link | mount | 464 | 463 | 5000 | |
| MakeStyles | mount | 1792 | 1787 | 50000 | |
| MenuButton | mount | 1426 | 1413 | 5000 | |
| MessageBar | mount | 1990 | 1983 | 5000 | |
| Nav | mount | 3182 | 3224 | 1000 | |
| OverflowSet | mount | 1029 | 1044 | 5000 | |
| Panel | mount | 1332 | 2028 | 1000 | |
| Persona | mount | 799 | 803 | 1000 | |
| Pivot | mount | 1378 | 1404 | 1000 | |
| PrimaryButton | mount | 1247 | 1272 | 5000 | |
| Rating | mount | 7424 | 7520 | 5000 | |
| SearchBox | mount | 1247 | 1244 | 5000 | |
| Shimmer | mount | 2494 | 2479 | 5000 | |
| Slider | mount | 1918 | 1941 | 5000 | |
| SpinButton | mount | 4905 | 4971 | 5000 | |
| Spinner | mount | 410 | 410 | 5000 | |
| SplitButton | mount | 3108 | 3110 | 5000 | |
| Stack | mount | 492 | 484 | 5000 | |
| StackWithIntrinsicChildren | mount | 1533 | 1548 | 5000 | |
| StackWithTextChildren | mount | 4490 | 4510 | 5000 | |
| SwatchColorPicker | mount | 10097 | 10130 | 5000 | |
| Tabs | mount | 1378 | 1378 | 1000 | |
| TagPicker | mount | 2415 | 2394 | 5000 | |
| TeachingBubble | mount | 11754 | 11772 | 5000 | |
| Text | mount | 401 | 428 | 5000 | |
| TextField | mount | 1370 | 1384 | 5000 | |
| ThemeProvider | mount | 1181 | 1186 | 5000 | |
| ThemeProvider | virtual-rerender | 587 | 604 | 5000 | |
| ThemeProviderNext | mount | 7048 | 7005 | 5000 | |
| Toggle | mount | 789 | 800 | 5000 | |
| buttonNative | mount | 112 | 116 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 151 | 140 | 1.08:1 |
| AnimationMinimalPerf.default | 417 | 395 | 1.06:1 |
| ChatMinimalPerf.default | 623 | 585 | 1.06:1 |
| FormMinimalPerf.default | 402 | 379 | 1.06:1 |
| LabelMinimalPerf.default | 393 | 370 | 1.06:1 |
| HeaderMinimalPerf.default | 367 | 350 | 1.05:1 |
| SegmentMinimalPerf.default | 356 | 340 | 1.05:1 |
| TableMinimalPerf.default | 409 | 390 | 1.05:1 |
| AttachmentMinimalPerf.default | 156 | 150 | 1.04:1 |
| TreeWith60ListItems.default | 171 | 164 | 1.04:1 |
| FlexMinimalPerf.default | 288 | 280 | 1.03:1 |
| HeaderSlotsPerf.default | 765 | 742 | 1.03:1 |
| PortalMinimalPerf.default | 183 | 178 | 1.03:1 |
| TextMinimalPerf.default | 345 | 334 | 1.03:1 |
| AttachmentSlotsPerf.default | 1140 | 1116 | 1.02:1 |
| ImageMinimalPerf.default | 374 | 366 | 1.02:1 |
| InputMinimalPerf.default | 1275 | 1247 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1255 | 1230 | 1.02:1 |
| MenuMinimalPerf.default | 847 | 834 | 1.02:1 |
| ToolbarMinimalPerf.default | 929 | 910 | 1.02:1 |
| TreeMinimalPerf.default | 793 | 777 | 1.02:1 |
| BoxMinimalPerf.default | 347 | 342 | 1.01:1 |
| CheckboxMinimalPerf.default | 2730 | 2710 | 1.01:1 |
| DatepickerMinimalPerf.default | 5351 | 5314 | 1.01:1 |
| DialogMinimalPerf.default | 754 | 746 | 1.01:1 |
| EmbedMinimalPerf.default | 4133 | 4102 | 1.01:1 |
| GridMinimalPerf.default | 336 | 332 | 1.01:1 |
| ReactionMinimalPerf.default | 367 | 362 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3737 | 3707 | 1.01:1 |
| TableManyItemsPerf.default | 1895 | 1875 | 1.01:1 |
| CustomToolbarPrototype.default | 3850 | 3801 | 1.01:1 |
| VideoMinimalPerf.default | 610 | 602 | 1.01:1 |
| AlertMinimalPerf.default | 271 | 270 | 1:1 |
| ButtonOverridesMissPerf.default | 1671 | 1669 | 1:1 |
| CardMinimalPerf.default | 540 | 541 | 1:1 |
| ChatWithPopoverPerf.default | 354 | 354 | 1:1 |
| DividerMinimalPerf.default | 345 | 344 | 1:1 |
| DropdownManyItemsPerf.default | 681 | 681 | 1:1 |
| DropdownMinimalPerf.default | 3089 | 3080 | 1:1 |
| ListNestedPerf.default | 544 | 545 | 1:1 |
| ListWith60ListItems.default | 634 | 633 | 1:1 |
| MenuButtonMinimalPerf.default | 1542 | 1549 | 1:1 |
| RosterPerf.default | 1131 | 1126 | 1:1 |
| ProviderMinimalPerf.default | 999 | 1004 | 1:1 |
| RadioGroupMinimalPerf.default | 437 | 437 | 1:1 |
| SkeletonMinimalPerf.default | 350 | 351 | 1:1 |
| SliderMinimalPerf.default | 1588 | 1586 | 1:1 |
| TextAreaMinimalPerf.default | 483 | 485 | 1:1 |
| ButtonMinimalPerf.default | 163 | 164 | 0.99:1 |
| ChatDuplicateMessagesPerf.default | 292 | 295 | 0.99:1 |
| LayoutMinimalPerf.default | 353 | 357 | 0.99:1 |
| PopupMinimalPerf.default | 561 | 566 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1676 | 1698 | 0.99:1 |
| IconMinimalPerf.default | 604 | 613 | 0.99:1 |
| AvatarMinimalPerf.default | 191 | 194 | 0.98:1 |
| CarouselMinimalPerf.default | 448 | 459 | 0.98:1 |
| ListMinimalPerf.default | 503 | 513 | 0.98:1 |
| LoaderMinimalPerf.default | 677 | 688 | 0.98:1 |
| RefMinimalPerf.default | 233 | 238 | 0.98:1 |
| TooltipMinimalPerf.default | 958 | 979 | 0.98:1 |
| ButtonSlotsPerf.default | 523 | 537 | 0.97:1 |
| StatusMinimalPerf.default | 652 | 669 | 0.97:1 |
| ListCommonPerf.default | 597 | 626 | 0.95:1 |
behowell
approved these changes
Jun 10, 2021
packages/react-button/src/components/ToggleButton/useToggleButtonStyles.ts
Outdated
Show resolved
Hide resolved
CXE Redmond - @microsoft/cxe-red
automation
moved this from In progress
to Reviewer approved
Jun 10, 2021
2 tasks
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Follow-up of #18468, #18497 and #18498.
This PR removes the legacy patterns that were being used in the
ToggleButtoncomponent in@fluentui/react-button, instead opting for using the patterns adopted by other converged components such asAvatarin@fluentui/react-avatar.