Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Small <Button> is using 3px border radius #28576

Closed
2 tasks done
chenxinyanc opened this issue Jul 19, 2023 · 0 comments
Closed
2 tasks done

[Bug]: Small <Button> is using 3px border radius #28576

chenxinyanc opened this issue Jul 19, 2023 · 0 comments
Labels
Component: Button Fluent UI react-components (v9)

Comments

@chenxinyanc
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

(Using CodeSandbox)

"@fluentui/react-components": "9.26.1",

Are you reporting Accessibility issue?

no

Reproduction

https://codesandbox.io/s/fluent-ui-v9-buttons-drpc8h

Bug Description

Actual Behavior

Small buttons are using 3px border radius.

image

Expected Behavior

Small buttons should be using 4px border radius per UX spec I suppose. Also 3px is not among the border radii series: https://master--628d031b55e942004ac95df1.chromatic.com/?path=/docs/theme-border-radii--page

image

Logs

No response

Requested priority

Normal

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
AbdulRehmanMehar added a commit to AbdulRehmanMehar/fluentui that referenced this issue Jul 19, 2023
@AbdulRehmanMehar
microsoft#28576: [Bug]: Small <Button> is using 3px border radius
fea71db
@AbdulRehmanMehar AbdulRehmanMehar mentioned this issue Jul 19, 2023
Merged
sopranopillow pushed a commit that referenced this issue Aug 25, 2023
@AbdulRehmanMehar
28576 small button is using 3px border radius (#28589)
5d42a5f 
* #28576: [Bug]: Small <Button> is using 3px border radius

* run yarn change

* updated the code to use token for border-radius

* updated the comment as per @sopranopillow's suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Button Fluent UI react-components (v9)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sopranopillow @chenxinyanc @spmonahan