Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple warnings with React/React-Dom 15.2.1 #4

Closed
mike-morr opened this issue Jul 23, 2016 · 4 comments
Closed

Multiple warnings with React/React-Dom 15.2.1 #4

mike-morr opened this issue Jul 23, 2016 · 4 comments

Comments

@mike-morr
Copy link

There appears to be issues when trying to use the library with 15.2.1. I was getting a bunch of warnings in my app that were not appearing in the demo (gulp serve) app. I bumped up the version of react and react-dom the demo is downloading from the CDN from 0.14.7 to 15.2.1 and the demo app started throwing the same warnings.

image

If I track it down, I'll post more info. So far the warnings are just cluttering up my console, nothing broken. The warnings seem to be throwing across multiple pages so a lot of files might need to be updated. The one page that I looked at appeared like the code was written exactly like the latest react docs said it should be written, but that was just a quick glance.

Link to warning page in react docs

@mike-morr
Copy link
Author

Also a big 👎 on React showing me warnings in red. I was having an issue and thought these were errors, so I started troubleshooting. My eyes skipped the word Warning and went right for the error message. So really my fault for not reading, but I am hard-coded to make red go away as soon as I see it.

Turned out I had my TextField trying to use the onchange event instead of onchanged. Onchange did nothing and onchanged works. Figured that out by looking at the API docs included in the demo, so thank you for that. 💯 for having pretty solid docs and a very well written demo app at this early stage.

@dzearing
Copy link
Member

Thanks for the heads up. We will keep this open to track. Right now we have been testing against 0.14.7 because we initially saw some performance concerns with 15.0.1. We will re-evaluate and address the warnings.

@dzearing
Copy link
Member

All warnings from Button, Checkbox, and FocusZone have been addressed. We still have TextField left.

@dzearing
Copy link
Member

These have been resolved.

mohanmaheshwari1 pushed a commit to mohanmaheshwari1/office-ui-fabric-react that referenced this issue Jul 23, 2019
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants