chore: update Popper to v2 #12530
Merged
chore: update Popper to v2 #12530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 68e3c8edb99faedd36069bd1911c10e9e28d80a2 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Potential regressions comparing to master
Perf comparison
Perf tests with no regressions
|
layershifter
force-pushed
the
chore/popper-v2
branch
from
a06cd4c
to
b45a722
Compare
layershifter
changed the title
layershifter
force-pushed
the
chore/popper-v2
branch
from
f5396dc
to
3fc9c5a
Compare
layershifter
added
the
Fluent UI react-northstar (v0)
layershifter
force-pushed
the
chore/popper-v2
branch
3 times, most recently
from
2d92731
to
47ebec7
Compare
layershifter
force-pushed
the
chore/popper-v2
branch
from
c7b92da
to
44a19bd
Compare
pompomon
reviewed
Apr 6, 2020
packages/fluentui/react-northstar/src/components/Popup/Popup.tsx
Outdated
Show resolved
Hide resolved
pompomon
reviewed
Apr 6, 2020
packages/fluentui/react-northstar/test/specs/utils/positioner/positioningHelper-test.ts
Show resolved
Hide resolved
…icrosoft/fluentui into chore/popper-v2 � Conflicts: � packages/fluentui/CHANGELOG.md
| @@ -1,14 +0,0 @@ | |||
| import * as PopperJs from 'popper.js'; | |||
There was a problem hiding this comment.
Consumers might be using similar mock. Don't you want to describe it in breaking changes?
| import * as React from 'react'; | ||
| import PopperJS from 'popper.js'; | ||
|
|
||
| // Temporary typings for modifiers |
| if (boundary === 'scrollParent') { | ||
| let boundariesNode = getScrollParent(element); | ||
|
|
||
| if (boundariesNode.nodeName === 'BODY') { |
There was a problem hiding this comment.
Why do you need to do this?
Isn't getScrollParent() doing the same?
Comment on lines
129
to
133
| flipBoundary: PropTypes.oneOfType([ | ||
| PropTypes.object as PropTypes.Requireable<Element>, | ||
| PropTypes.oneOf<'scrollParent' | 'window' | 'viewport'>(['scrollParent', 'window', 'viewport']), | ||
| PropTypes.object as PropTypes.Requireable<HTMLElement>, | ||
| PropTypes.arrayOf(PropTypes.object) as PropTypes.Requireable<HTMLElement[]>, | ||
| PropTypes.oneOf<'clippingParents' | 'window' | 'scrollParent'>(['clippingParents', 'window', 'scrollParent']), | ||
| ]), |
There was a problem hiding this comment.
nit: create a separate propType? or move it to createCommon?
miroslavstastny
approved these changes
Apr 7, 2020
…icrosoft/fluentui into chore/popper-v2 � Conflicts: � README.md � packages/fluentui/CHANGELOG.md � packages/fluentui/react-northstar/package.json
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
* chore: update Popper to v2 * remove console.logs * update UTs * update test's title * fix proptypes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeBREAKING CHANGES
All changes are related to all components that consume
Popper.offsetcan't be specified asstringanymorePrevious implementation based on strings was complicated as for RTL support it required to parse strings. V2 changed this behavior and accepts a tuple or a function.
The same options can be used for consumers:
Before
After
Browser support
Additional polyfills are required for IE11:
Array.prototype.findPromiseObject.assignMore details: https://popper.js.org/docs/v2/browser-support/
This PR upgrades Popper's version to V2, detailed announcement. Key improvements:
Caveats 👀
paddingAs V2 doesn't allow to use
margins anymore , we had to usepadding(thanks to @pompomon) to set an offset whenPopup/Tooltiphas a pointing beak. However, this means that our handing of clicks insidePopup/Tooltipcontent should be moved tocontentslot, that's why I introducedpointerEventsproperties there.Follow ups 💅
update()is support in V2useDeepMemo()hookMicrosoft Reviewers: Open in CodeFlow