fix(Popup): update offsets computations #13002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
msft-github-bot
added
the
Fluent UI react-northstar (v0)
layershifter
commented
May 5, 2020
| @@ -13,7 +13,7 @@ const popupContentStyles: ComponentSlotStylesPrepared<PopupContentStylesProps, P | |||
| pointerEvents: 'none', | |||
| ...getContainerStyles({ | |||
| placement: p.basePlacement, | |||
| margin: v.pointerMargin, | |||
| padding: v.pointerMargin, | |||
There was a problem hiding this comment.
It's actually padding. Decided to keep variable's name to avoid breaking changes
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: aa2d3f52cfc21c8c15e87e46947f43c2249339b2 (build) |
pompomon
approved these changes
May 6, 2020
…/microsoft/fluentui into fix/popup-padding
…/microsoft/fluentui into fix/popup-padding � Conflicts: � packages/fluentui/CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
In #12577 I fixed sizes of pointers, but during Popper update (#12530) I missed this update. I checked the issue and we should include
paddingwhen we are computing offsets. It's annoying that Screener can't catch such issues 👎Before
After
(with
pointerMargin: pxToRem(20))(with
pointerMargin: pxToRem(30))Focus areas to test
(optional)
Microsoft Reviewers: Open in CodeFlow