-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): fix displaying custom clearIndicator
prop
#13486
Merged
kolaps33
merged 45 commits into
microsoft:master
from
kolaps33:mituron/dropdown-clearable
Jun 10, 2020
Merged
fix(dropdown): fix displaying custom clearIndicator
prop
#13486
kolaps33
merged 45 commits into
microsoft:master
from
kolaps33:mituron/dropdown-clearable
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolaps33
requested review from
dvdzkwsk,
dzearing,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny,
mnajdova and
pompomon
as code owners
June 5, 2020 15:25
msft-github-bot
added
the
Fluent UI react-northstar (v0)
Work related to Fluent UI V0
label
Jun 5, 2020
kolaps33
changed the title
fix(dropdown): fix display custom
fix(dropdown): fix displaying custom Jun 5, 2020
clearIndicator
propclearIndicator
prop
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
packages/fluentui/react-northstar/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
packages/fluentui/react-northstar/src/themes/teams/components/Dropdown/dropdownStyles.ts
Outdated
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 08f405e64129cbe870660edcafb385e90b977387 (build) |
pompomon
approved these changes
Jun 10, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
add condition to the style if there is custom clearIndicator given, then don't display default background image
Focus areas to test
Tests are done via screener :