Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): fix displaying custom clearIndicator prop #13486

Merged
merged 45 commits into from
Jun 10, 2020
Merged

fix(dropdown): fix displaying custom clearIndicator prop #13486

merged 45 commits into from
Jun 10, 2020

Conversation

kolaps33
Copy link
Contributor

@kolaps33 kolaps33 commented Jun 5, 2020

Pull request checklist

Description of changes

add condition to the style if there is custom clearIndicator given, then don't display default background image

Focus areas to test

Tests are done via screener :
image

Milan Turon added 30 commits April 3, 2020 14:52
@msft-github-bot msft-github-bot added the Fluent UI react-northstar (v0) Work related to Fluent UI V0 label Jun 5, 2020
@kolaps33 kolaps33 changed the title fix(dropdown): fix display custom clearIndicator prop fix(dropdown): fix displaying custom clearIndicator prop Jun 5, 2020
@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jun 5, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 864 897 5000
ButtonNext mount 423 425 5000
Checkbox mount 1568 1623 5000
CheckboxBase mount 1323 1354 5000
CheckboxNext mount 1554 1597 5000
ChoiceGroup mount 4977 4935 5000
ComboBox mount 946 930 1000
CommandBar mount 7635 7623 1000
ContextualMenu mount 13351 12914 1000
DefaultButton mount 1111 1089 5000
DetailsRow mount 3571 3549 5000
DetailsRowFast mount 3513 3552 5000
DetailsRowNoStyles mount 3397 3335 5000
Dialog mount 1461 1498 1000
DocumentCardTitle mount 1789 1831 1000
Dropdown mount 2439 2435 5000
FocusZone mount 1769 1779 5000
IconButton mount 1714 1732 5000
Label mount 339 359 5000
Link mount 488 487 5000
LinkNext mount 501 519 5000
MenuButton mount 1439 1447 5000
Nav mount 3304 3180 1000
Panel mount 1467 1431 1000
Persona mount 821 820 1000
Pivot mount 1394 1399 1000
PivotNext mount 1348 1347 1000
PrimaryButton mount 1224 1294 5000
SearchBox mount 1264 1257 5000
Slider mount 1499 1503 5000
SliderNext mount 2010 1944 5000
Spinner mount 458 426 5000
SplitButton mount 3146 3175 5000
Stack mount 502 513 5000
StackWithIntrinsicChildren mount 1905 1939 5000
StackWithTextChildren mount 4957 4941 5000
TagPicker mount 2827 2803 5000
Text mount 446 422 5000
TextField mount 1421 1421 5000
ThemeProvider mount 2839 2868 5000
ThemeProvider virtual-rerender 525 535 5000
Toggle mount 913 922 5000
ToggleNext mount 893 864 5000
button mount 96 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.44 0.49 0.9:1 2000 874
🦄 Button.Fluent 0.1 0.18 0.56:1 5000 521
🔧 Checkbox.Fluent 0.61 0.31 1.97:1 1000 608
🦄 Dialog.Fluent 0.14 0.21 0.67:1 5000 716
🔧 Dropdown.Fluent 3.27 0.43 7.6:1 1000 3268
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 677
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 353
🔧 Slider.Fluent 1.57 0.35 4.49:1 1000 1574
🔧 Text.Fluent 0.07 0.02 3.5:1 5000 330
🦄 Tooltip.Fluent 0.1 17.69 0.01:1 5000 475

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ImageMinimalPerf.default 363 328 1.11:1
CardMinimalPerf.default 553 511 1.08:1
ButtonMinimalPerf.default 164 155 1.06:1
FormMinimalPerf.default 385 365 1.05:1
HeaderMinimalPerf.default 350 334 1.05:1
HierarchicalTreeMinimalPerf.default 421 402 1.05:1
LabelMinimalPerf.default 396 376 1.05:1
TextMinimalPerf.default 342 325 1.05:1
Image.Fluent 353 335 1.05:1
DividerMinimalPerf.default 350 336 1.04:1
ListCommonPerf.default 948 914 1.04:1
ListWith60ListItems.default 1086 1047 1.04:1
SegmentMinimalPerf.default 336 323 1.04:1
MenuMinimalPerf.default 840 816 1.03:1
RefMinimalPerf.default 196 190 1.03:1
ToolbarMinimalPerf.default 933 910 1.03:1
Dialog.Fluent 716 695 1.03:1
CarouselMinimalPerf.default 437 428 1.02:1
ChatMinimalPerf.default 588 576 1.02:1
ChatWithPopoverPerf.default 453 446 1.02:1
DialogMinimalPerf.default 717 706 1.02:1
FlexMinimalPerf.default 280 274 1.02:1
InputMinimalPerf.default 1012 996 1.02:1
LoaderMinimalPerf.default 715 701 1.02:1
MenuButtonMinimalPerf.default 1209 1191 1.02:1
ProviderMinimalPerf.default 840 825 1.02:1
RadioGroupMinimalPerf.default 392 383 1.02:1
IconMinimalPerf.default 652 640 1.02:1
Checkbox.Fluent 608 594 1.02:1
Slider.Fluent 1574 1542 1.02:1
AttachmentSlotsPerf.default 1122 1110 1.01:1
DropdownMinimalPerf.default 3261 3228 1.01:1
EmbedMinimalPerf.default 1846 1822 1.01:1
ListNestedPerf.default 857 847 1.01:1
TextAreaMinimalPerf.default 454 448 1.01:1
CustomToolbarPrototype.default 3873 3825 1.01:1
TreeWith60ListItems.default 215 213 1.01:1
Dropdown.Fluent 3268 3242 1.01:1
AvatarMinimalPerf.default 468 470 1:1
ButtonSlotsPerf.default 581 581 1:1
ItemLayoutMinimalPerf.default 1282 1276 1:1
ListMinimalPerf.default 452 451 1:1
PortalMinimalPerf.default 117 117 1:1
StatusMinimalPerf.default 659 660 1:1
TableManyItemsPerf.default 2106 2096 1:1
AlertMinimalPerf.default 276 279 0.99:1
BoxMinimalPerf.default 324 328 0.99:1
ChatDuplicateMessagesPerf.default 399 404 0.99:1
CheckboxMinimalPerf.default 2762 2780 0.99:1
DropdownManyItemsPerf.default 1336 1343 0.99:1
PopupMinimalPerf.default 267 271 0.99:1
ProviderMergeThemesPerf.default 2133 2144 0.99:1
ReactionMinimalPerf.default 363 366 0.99:1
SliderMinimalPerf.default 1542 1552 0.99:1
SplitButtonMinimalPerf.default 3335 3352 0.99:1
TableMinimalPerf.default 375 378 0.99:1
TooltipMinimalPerf.default 733 738 0.99:1
VideoMinimalPerf.default 584 592 0.99:1
Avatar.Fluent 874 881 0.99:1
Button.Fluent 521 526 0.99:1
Icon.Fluent 677 684 0.99:1
Tooltip.Fluent 475 479 0.99:1
AccordionMinimalPerf.default 127 130 0.98:1
GridMinimalPerf.default 636 652 0.98:1
LayoutMinimalPerf.default 378 387 0.98:1
Text.Fluent 330 337 0.98:1
AttachmentMinimalPerf.default 141 146 0.97:1
HeaderSlotsPerf.default 750 773 0.97:1
TreeMinimalPerf.default 822 845 0.97:1
AnimationMinimalPerf.default 593 616 0.96:1

@size-auditor
Copy link

size-auditor bot commented Jun 5, 2020

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 08f405e64129cbe870660edcafb385e90b977387 (build)

@kolaps33 kolaps33 merged commit 831de1b into microsoft:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants