Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Charting: LineChart - Chart redraw after legend selection issue resolved. #15117

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Charting: LineChart - Chart redraw after legend selection issue resolved. #15117

merged 3 commits into from
Sep 18, 2020

Conversation

jameelakowsar
Copy link
Contributor

@jameelakowsar jameelakowsar commented Sep 18, 2020 •
edited

Pull request checklist

  • Include a change request file using $ yarn change

Description of changes

In line chart, While selecting single legend, chart needs to be redraw. Updated data.

Focus areas to test

Line chart.

Line chart after selection single legend, before fix

image

After fix

image

Jameela Kowsar Shaik (Zen3 Infosolutions America Inc) added 3 commits September 18, 2020 13:03
@size-auditor
Copy link

size-auditor bot commented Sep 18, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: b4c3f90

Possible causes

  • The baseline build b4c3f90 is broken
  • The Size Auditor run for the baseline build b4c3f90 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2996a4c:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration
microsoft/fluentui: codesandbox-react-next-template Configuration
microsoft/fluentui: codesandbox-react-northstar-template Configuration

@msft-github-bot
Copy link
Contributor

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 951 944 5000
Breadcrumb mount 40355 40270 5000
BreadcrumbNext mount 155576 153623 5000
ButtonNext mount 599 571 5000
Checkbox mount 1617 1657 5000
CheckboxBase mount 1371 1421 5000
CheckboxNext mount 1620 1609 5000
ChoiceGroup mount 5125 5124 5000
ChoiceGroupNext mount 5133 5110 5000
ComboBox mount 916 955 1000
CommandBar mount 7496 7416 1000
ContextualMenu mount 12741 12605 1000
DefaultButton mount 1130 1178 5000
DetailsRow mount 3593 3662 5000
DetailsRowFast mount 3584 3630 5000
DetailsRowNoStyles mount 3428 3472 5000
Dialog mount 1541 1473 1000
DocumentCardTitle mount 1763 1786 1000
Dropdown mount 2666 2687 5000
FocusZone mount 1782 1791 5000
IconButton mount 1848 1799 5000
Label mount 340 349 5000
Link mount 458 457 5000
LinkNext mount 480 496 5000
MenuButton mount 1504 1517 5000
MessageBar mount 2054 2031 5000
MessageBarNext mount 1999 2014 5000
Nav mount 3307 3234 1000
OverflowSet mount 1417 1427 5000
OverflowSetNext mount 1010 1040 5000
Panel mount 1427 1458 1000
Persona mount 872 846 1000
Pivot mount 1447 1489 1000
PivotNext mount 1430 1441 1000
PrimaryButton mount 1301 1285 5000
Rating mount 7946 8011 5000
RatingNext mount 7886 7850 5000
SearchBox mount 1371 1320 5000
SearchBoxNext mount 1404 1391 5000
Shimmer mount 2749 2662 5000
ShimmerNext mount 2688 2712 5000
Slider mount 1522 1518 5000
SliderNext mount 1953 1968 5000
SpinButton mount 5005 5049 5000
SpinButtonNext mount 5177 5164 5000
Spinner mount 406 437 5000
SplitButton mount 3236 3218 5000
Stack mount 535 552 5000
StackWithIntrinsicChildren mount 1923 2027 5000
StackWithTextChildren mount 5195 5293 5000
SwatchColorPicker mount 10373 10497 5000
SwatchColorPickerNext mount 10414 10388 5000
TagPicker mount 2826 2846 5000
TeachingBubble mount 49034 49061 5000
TeachingBubbleNext mount 49713 48934 5000
Text mount 424 441 5000
TextField mount 1403 1404 5000
ThemeProvider mount 2409 2404 5000
ThemeProvider virtual-rerender 597 597 5000
Toggle mount 848 863 5000
ToggleNext mount 824 831 5000
button mount 111 115 5000

Perf Analysis (Fluent)

⚠️ 4 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
ButtonOverridesMissPerf.default 1721 43 40.02:1 analysis
ButtonUseCssNestingPerf.default 1129 46 24.54:1 analysis
ButtonUseCssPerf.default 862 44 19.59:1 analysis
ChatWithPopoverPerf.default 492 505 0.97:1 analysis
Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.47 0.5 0.94:1 2000 935
🦄 Button.Fluent 0.12 0.2 0.6:1 5000 617
🔧 Checkbox.Fluent 0.66 0.39 1.69:1 1000 659
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 840
🔧 Dropdown.Fluent 2.94 0.48 6.13:1 1000 2944
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 765
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 445
🔧 Slider.Fluent 1.6 0.36 4.44:1 1000 1595
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 401
🦄 Tooltip.Fluent 0.12 14.99 0.01:1 5000 579

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
PortalMinimalPerf.default 170 127 1.34:1
ImageMinimalPerf.default 494 375 1.32:1
RefMinimalPerf.default 247 190 1.3:1
AttachmentMinimalPerf.default 196 155 1.26:1
DividerMinimalPerf.default 438 353 1.24:1
FlexMinimalPerf.default 361 292 1.24:1
FormMinimalPerf.default 511 421 1.21:1
RadioGroupMinimalPerf.default 495 417 1.19:1
SegmentMinimalPerf.default 409 348 1.18:1
IconMinimalPerf.default 787 665 1.18:1
HeaderMinimalPerf.default 424 364 1.16:1
TableMinimalPerf.default 474 409 1.16:1
AnimationMinimalPerf.default 443 384 1.15:1
LabelMinimalPerf.default 480 418 1.15:1
ReactionMinimalPerf.default 480 419 1.15:1
StatusMinimalPerf.default 828 719 1.15:1
Image.Fluent 445 389 1.14:1
ButtonMinimalPerf.default 196 173 1.13:1
ListMinimalPerf.default 535 478 1.12:1
Tooltip.Fluent 579 515 1.12:1
GridMinimalPerf.default 383 345 1.11:1
LayoutMinimalPerf.default 454 408 1.11:1
SkeletonMinimalPerf.default 482 435 1.11:1
TooltipMinimalPerf.default 859 774 1.11:1
PopupMinimalPerf.default 735 667 1.1:1
Button.Fluent 617 559 1.1:1
Dialog.Fluent 840 767 1.1:1
BoxMinimalPerf.default 401 367 1.09:1
ProviderMinimalPerf.default 986 902 1.09:1
AlertMinimalPerf.default 346 321 1.08:1
CardMinimalPerf.default 634 585 1.08:1
MenuMinimalPerf.default 949 879 1.08:1
TextMinimalPerf.default 399 370 1.08:1
VideoMinimalPerf.default 697 643 1.08:1
Text.Fluent 401 371 1.08:1
AccordionMinimalPerf.default 160 150 1.07:1
MenuButtonMinimalPerf.default 1673 1561 1.07:1
TextAreaMinimalPerf.default 546 511 1.07:1
ToolbarMinimalPerf.default 1043 978 1.07:1
HeaderSlotsPerf.default 941 888 1.06:1
LoaderMinimalPerf.default 766 726 1.06:1
Avatar.Fluent 935 883 1.06:1
Icon.Fluent 765 720 1.06:1
DialogMinimalPerf.default 826 783 1.05:1
ProviderMergeThemesPerf.default 1940 1844 1.05:1
AvatarMinimalPerf.default 503 484 1.04:1
InputMinimalPerf.default 1347 1289 1.04:1
CustomToolbarPrototype.default 3786 3654 1.04:1
Checkbox.Fluent 659 632 1.04:1
ButtonSlotsPerf.default 633 616 1.03:1
CheckboxMinimalPerf.default 2951 2862 1.03:1
EmbedMinimalPerf.default 2076 2021 1.03:1
ItemLayoutMinimalPerf.default 1386 1341 1.03:1
TreeMinimalPerf.default 964 935 1.03:1
AttachmentSlotsPerf.default 1198 1177 1.02:1
SplitButtonMinimalPerf.default 3954 3891 1.02:1
TableManyItemsPerf.default 2398 2343 1.02:1
ChatDuplicateMessagesPerf.default 432 427 1.01:1
ChatMinimalPerf.default 693 684 1.01:1
DropdownManyItemsPerf.default 812 802 1.01:1
DropdownMinimalPerf.default 2915 2887 1.01:1
SliderMinimalPerf.default 1624 1607 1.01:1
Dropdown.Fluent 2944 2904 1.01:1
Slider.Fluent 1595 1579 1.01:1
CarouselMinimalPerf.default 472 478 0.99:1
TreeWith60ListItems.default 212 225 0.94:1
ListWith60ListItems.default 985 1111 0.89:1
ListCommonPerf.default 709 1008 0.7:1
ListNestedPerf.default 633 918 0.69:1

@Raghurk Raghurk merged commit 1bfa9ea into microsoft:master Sep 18, 2020
@NewFuture NewFuture mentioned this pull request Sep 22, 2020
Closed
@msft-github-bot
Copy link
Contributor

🎉@uifabric/charting@v4.2.0 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raghurk Raghurk Raghurk approved these changes

Assignees
No one assigned
Labels
Package: charting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jameelakowsar @msft-github-bot @Raghurk