Add size check to react-northstar build #16686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 6896697d21ee038e3a4921b033d5f1f68537aed0 (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e056ee6:
|
ecraig12345
requested changes
Jan 29, 2021
ecraig12345
previously approved these changes
Jan 29, 2021
Hi @ecraig12345 the webpack upgrade actually breaks the size-auditor. I pushed new changes that should fix it for fabric + added N* components in it. Splitting it into separate jobs would be welcome for reducing the time |
Ah okay... 😬 @dzearing should take a look at your changes since he did the webpack upgrade. |
|
Here's what needs to happen to split the jobs. A couple easy parts first:
(As an alternative to both of these, I guess you could add a separate package Next split up the jobs:
- job: build-react
timeoutInMinutes: 75
pool:
vmImage: 'windows-2019'
steps:
- task: NodeTool@0
inputs:
versionSpec: '12.x'
displayName: 'Install Node.js'
- script: npx midgard-yarn install
displayName: yarn
- script: yarn build --to @fluentui/react @fluentui/react-button @fluentui/react-compose --no-cache
displayName: yarn build to @fluentui/react
- script: yarn workspace test-bundles bundle:size --package @fluentui/react
displayName: yarn bundle test-bundles
- script: yarn bundlesizecollect
displayName: 'Collate Bundle Size Information'
- task: PublishBuildArtifacts@1
displayName: 'Publish Bundle Size information to Azure Dev Ops Artifacts'
inputs:
PathtoPublish: 'apps/test-bundles/dist/bundlesizes.json'
ArtifactName: bundlesizes-react
- task: PublishBuildArtifacts@1
displayName: 'Publish Artifact dist folder upon build for debug'
inputs:
PathtoPublish: 'apps/test-bundles/dist'
ArtifactName: distdrop-react
- job: build-northstar
timeoutInMinutes: 75
pool:
vmImage: 'windows-2019'
steps:
- task: NodeTool@0
inputs:
versionSpec: '12.x'
displayName: 'Install Node.js'
- script: npx midgard-yarn install
displayName: yarn
- script: yarn build --to @fluentui/react-northstar --no-cache
displayName: yarn build to @fluentui/react-northstar
- script: yarn workspace test-bundles bundle:size --package @fluentui/react-northstar
displayName: yarn bundle test-bundles
- script: yarn bundlesizecollect
displayName: 'Collate Bundle Size Information'
- task: PublishBuildArtifacts@1
displayName: 'Publish Bundle Size information to Azure Dev Ops Artifacts'
inputs:
PathtoPublish: 'apps/test-bundles/dist/bundlesizes.json'
ArtifactName: bundlesizes-northstar
- task: PublishBuildArtifacts@1
displayName: 'Publish Artifact dist folder upon build for debug'
inputs:
PathtoPublish: 'apps/test-bundles/dist'
ArtifactName: distdrop-northstarThe next part is the tough one. Currently the actual size auditor back end (what the Option 1: add a merging task to the
|
layershifter
reviewed
Feb 3, 2021
layershifter
reviewed
Feb 3, 2021
petdud
commented
Feb 3, 2021
ecraig12345
reviewed
Feb 4, 2021
ecraig12345
reviewed
Feb 4, 2021
|
Commenter does not have sufficient privileges for PR 16686 in repo microsoft/fluentui |
added 2 commits
February 11, 2021 09:29
…-react-n-build # Conflicts: # apps/test-bundles/package.json
|
@ecraig12345 It seems that the lightrail job is taking the bundlesizes.json from the build_react job and not the bundlesizes.json from the merge job that contains React + React N* sizes. Do you know how does the lightrail work or how is it configured? I was looking at the lightrail pipeline and found only this: devopsDropFolderName : drop This should be the last thing to solve hopefully. Thanks again for all your help |
added 11 commits
February 11, 2021 20:41
…-react-n-build # Conflicts: # apps/test-bundles/package.json
2 tasks
added 2 commits
February 16, 2021 09:56
…-react-n-build # Conflicts: # apps/test-bundles/package.json
layershifter
approved these changes
Feb 16, 2021
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Bundle size auditor for Fabric is broken since the update to Webpack 5 due to the Tree shaking. This PR is fixing this by creating new file with component import and console log + adding N* to the auditor check.
(give an overview)
Focus areas to test
(optional)