Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating size auditor config for upcoming PR #16686 #16995

Merged
merged 1 commit into from Feb 16, 2021
Merged

Updating size auditor config for upcoming PR #16686 #16995

merged 1 commit into from Feb 16, 2021

Conversation

petdud
Copy link
Contributor

@petdud petdud commented Feb 15, 2021 •
edited by ling1726

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

We are updating the size auditor to handle React and React Northstar for this PR: #16686

Looking deeper into SizeAuditor code we noticed that:

  • devopsWebpackStatsArtifactName was never being used
  • devopsAssemblyArtifactName needs to be set if there is more than 1 drop artifact, currently it works because ADO returns the correct drop even with an empty artifact name, however this will no longer be the case after Add size check to react-northstar build #16686
  • SizeAuditor always pull config from the master branch of a repo, which makes it impossible to change the config in a PR

Focus areas to test

(optional)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 476d5e7:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 15, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 7d58886e890a58df684140583bbf786a57c24926 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 850 859 5000
BaseButton mount 912 888 5000
Breadcrumb mount 41671 41735 5000
ButtonNext mount 712 705 5000
Checkbox mount 1567 1562 5000
CheckboxBase mount 1299 1308 5000
ChoiceGroup mount 4962 4986 5000
ComboBox mount 981 987 1000
CommandBar mount 9988 10052 1000
ContextualMenu mount 5997 6080 1000
DefaultButton mount 1175 1156 5000
DetailsRow mount 3644 3624 5000
DetailsRowFast mount 3725 3653 5000
DetailsRowNoStyles mount 3602 3474 5000
Dialog mount 1473 1464 1000
DocumentCardTitle mount 1785 1806 1000
Dropdown mount 3364 3409 5000
FocusTrapZone mount 1771 1747 5000
FocusZone mount 1795 1724 5000
IconButton mount 1832 1841 5000
Label mount 331 343 5000
Layer mount 1829 1822 5000
Link mount 463 467 5000
MakeStyles mount 1943 1953 50000
MenuButton mount 1512 1496 5000
MessageBar mount 1987 2021 5000
Nav mount 3410 3373 1000
OverflowSet mount 1016 1032 5000
Panel mount 1431 1450 1000
Persona mount 811 817 1000
Pivot mount 1441 1441 1000
PrimaryButton mount 1318 1337 5000
Rating mount 7791 7820 5000
SearchBox mount 1365 1307 5000
Shimmer mount 2567 2613 5000
Slider mount 1966 1864 5000
SpinButton mount 5131 5079 5000
Spinner mount 407 403 5000
SplitButton mount 3180 3194 5000
Stack mount 503 503 5000
StackWithIntrinsicChildren mount 1593 1618 5000
StackWithTextChildren mount 4742 4712 5000
SwatchColorPicker mount 10297 10387 5000
Tabs mount 1378 1408 1000
TagPicker mount 2824 2847 5000
TeachingBubble mount 11592 11506 5000
Text mount 430 422 5000
TextField mount 1364 1411 5000
ThemeProvider mount 1168 1163 5000
ThemeProvider virtual-rerender 582 581 5000
ThemeProviderNext mount 1933 1931 5000
Toggle mount 802 809 5000
buttonNative mount 110 108 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.49 0.39:1 2000 375
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 666
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 642
🎯 Dialog.Fluent 0.17 0.22 0.77:1 5000 839
🔧 Dropdown.Fluent 3.06 0.45 6.8:1 1000 3055
🔧 Icon.Fluent 0.15 0.06 2.5:1 5000 742
🎯 Image.Fluent 0.09 0.12 0.75:1 5000 426
🔧 Slider.Fluent 1.59 0.45 3.53:1 1000 1590
🔧 Text.Fluent 0.08 0.03 2.67:1 5000 412
🦄 Tooltip.Fluent 0.12 0.88 0.14:1 5000 591

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 209 185 1.13:1
ButtonMinimalPerf.default 216 194 1.11:1
Text.Fluent 412 375 1.1:1
ChatDuplicateMessagesPerf.default 415 379 1.09:1
Button.Fluent 666 612 1.09:1
PortalMinimalPerf.default 179 165 1.08:1
AttachmentMinimalPerf.default 193 180 1.07:1
ButtonSlotsPerf.default 644 604 1.07:1
StatusMinimalPerf.default 831 780 1.07:1
AlertMinimalPerf.default 337 317 1.06:1
AccordionMinimalPerf.default 185 177 1.05:1
ChatWithPopoverPerf.default 477 454 1.05:1
ListMinimalPerf.default 561 536 1.05:1
RefMinimalPerf.default 255 243 1.05:1
TextAreaMinimalPerf.default 586 557 1.05:1
CardMinimalPerf.default 633 608 1.04:1
DividerMinimalPerf.default 443 428 1.04:1
DropdownMinimalPerf.default 3142 3031 1.04:1
IconMinimalPerf.default 728 702 1.04:1
AnimationMinimalPerf.default 442 429 1.03:1
HeaderSlotsPerf.default 876 852 1.03:1
ImageMinimalPerf.default 432 421 1.03:1
LabelMinimalPerf.default 470 455 1.03:1
SkeletonMinimalPerf.default 407 394 1.03:1
TableMinimalPerf.default 449 436 1.03:1
TextMinimalPerf.default 408 397 1.03:1
Avatar.Fluent 375 364 1.03:1
Dialog.Fluent 839 817 1.03:1
Icon.Fluent 742 723 1.03:1
Image.Fluent 426 413 1.03:1
AttachmentSlotsPerf.default 1288 1265 1.02:1
CheckboxMinimalPerf.default 2918 2858 1.02:1
DialogMinimalPerf.default 852 836 1.02:1
LayoutMinimalPerf.default 460 452 1.02:1
ListCommonPerf.default 726 710 1.02:1
RosterPerf.default 1325 1297 1.02:1
PopupMinimalPerf.default 729 717 1.02:1
ProviderMinimalPerf.default 1010 993 1.02:1
ReactionMinimalPerf.default 455 445 1.02:1
SliderMinimalPerf.default 1664 1633 1.02:1
Tooltip.Fluent 591 581 1.02:1
BoxMinimalPerf.default 404 401 1.01:1
ButtonUseCssPerf.default 867 861 1.01:1
CarouselMinimalPerf.default 524 518 1.01:1
DatepickerMinimalPerf.default 48737 48156 1.01:1
DropdownManyItemsPerf.default 784 777 1.01:1
FlexMinimalPerf.default 343 339 1.01:1
ListWith60ListItems.default 657 652 1.01:1
LoaderMinimalPerf.default 751 742 1.01:1
MenuMinimalPerf.default 977 972 1.01:1
MenuButtonMinimalPerf.default 1666 1645 1.01:1
CustomToolbarPrototype.default 3791 3772 1.01:1
ButtonUseCssNestingPerf.default 1121 1117 1:1
ChatMinimalPerf.default 657 658 1:1
FormMinimalPerf.default 507 506 1:1
HeaderMinimalPerf.default 417 416 1:1
ItemLayoutMinimalPerf.default 1304 1308 1:1
ListNestedPerf.default 635 637 1:1
SplitButtonMinimalPerf.default 3944 3943 1:1
ProviderMergeThemesPerf.default 1568 1580 0.99:1
RadioGroupMinimalPerf.default 493 500 0.99:1
SegmentMinimalPerf.default 398 404 0.99:1
TableManyItemsPerf.default 2182 2197 0.99:1
ToolbarMinimalPerf.default 1019 1033 0.99:1
TooltipMinimalPerf.default 849 857 0.99:1
Checkbox.Fluent 642 647 0.99:1
AvatarMinimalPerf.default 219 224 0.98:1
ButtonOverridesMissPerf.default 1743 1770 0.98:1
EmbedMinimalPerf.default 4379 4461 0.98:1
InputMinimalPerf.default 1301 1322 0.98:1
Dropdown.Fluent 3055 3110 0.98:1
Slider.Fluent 1590 1625 0.98:1
GridMinimalPerf.default 406 419 0.97:1
TreeMinimalPerf.default 866 891 0.97:1
VideoMinimalPerf.default 704 733 0.96:1

@petdud petdud changed the title Remove unused devopsWebpackStatsArtifactName and add devopsAssemblyAr… Updating size auditor config for PR #16686 Feb 15, 2021
@petdud petdud changed the title Updating size auditor config for PR #16686 Updating size auditor config for upcoming PR #16686 Feb 15, 2021
@ling1726 ling1726 merged commit 0e07d35 into microsoft:master Feb 16, 2021
joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
@petdud @joshualamusga1
Remove unused devopsWebpackStatsArtifactName and add devopsAssemblyAr…
8b0647a 
…tifactName (microsoft#16995)

Co-authored-by: Petr Duda <petrduda@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@aftab-hassan aftab-hassan Awaiting requested review from aftab-hassan

Assignees

@joschect joschect

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@petdud @fabricteam @ecraig12345 @ling1726 @joschect