Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apple links #16978

Merged
merged 2 commits into from
Feb 13, 2021
Merged

Conversation

markavitale
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

The fluentui-apple repository recently updated its default branch to be named 'main'. Since there are some links to the old default branch ('master') in our documentation, update them to be correct. There were a few other minor changes due to some refactoring in the fluentui-apple repository.

Focus areas to test

Ensure the links properly take users to the new default branch of the Microsoft/fluentui-apple GitHub repository. Tested by running the website locally and clicking through the links.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7edbfa2:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 12, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 47e86c8e0a16bc3f2b47ae2d1113fc97871602ce (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 874 871 5000
BaseButton mount 916 964 5000
Breadcrumb mount 42406 42201 5000
ButtonNext mount 691 681 5000
Checkbox mount 1550 1559 5000
CheckboxBase mount 1347 1350 5000
ChoiceGroup mount 4869 4830 5000
ComboBox mount 1005 988 1000
CommandBar mount 9992 10136 1000
ContextualMenu mount 6155 6080 1000
DefaultButton mount 1193 1169 5000
DetailsRow mount 3660 3690 5000
DetailsRowFast mount 3731 3620 5000
DetailsRowNoStyles mount 3535 3547 5000
Dialog mount 1493 1510 1000
DocumentCardTitle mount 1812 1801 1000
Dropdown mount 3398 3414 5000
FocusTrapZone mount 1829 1838 5000
FocusZone mount 1805 1822 5000
IconButton mount 1883 1844 5000
Label mount 330 331 5000
Layer mount 1820 1834 5000
Link mount 471 480 5000
MakeStyles mount 1946 1961 50000
MenuButton mount 1499 1540 5000
MessageBar mount 2007 1974 5000
Nav mount 3375 3414 1000
OverflowSet mount 1099 1066 5000
Panel mount 1460 1481 1000
Persona mount 866 854 1000
Pivot mount 1457 1393 1000
PrimaryButton mount 1307 1303 5000
Rating mount 7877 7961 5000
SearchBox mount 1434 1419 5000
Shimmer mount 2688 2730 5000
Slider mount 1908 1938 5000
SpinButton mount 5204 5188 5000
Spinner mount 410 421 5000
SplitButton mount 3265 3247 5000
Stack mount 491 505 5000
StackWithIntrinsicChildren mount 1598 1650 5000
StackWithTextChildren mount 4798 4841 5000
SwatchColorPicker mount 10648 10619 5000
Tabs mount 1394 1451 1000
TagPicker mount 2853 2874 5000
TeachingBubble mount 11803 11710 5000
Text mount 438 426 5000
TextField mount 1432 1418 5000
ThemeProvider mount 1203 1179 5000
ThemeProvider virtual-rerender 609 594 5000
ThemeProviderNext mount 1981 1970 5000
Toggle mount 832 824 5000
buttonNative mount 114 118 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.19 0.48 0.4:1 2000 385
🦄 Button.Fluent 0.13 0.21 0.62:1 5000 645
🔧 Checkbox.Fluent 0.68 0.37 1.84:1 1000 677
🎯 Dialog.Fluent 0.17 0.23 0.74:1 5000 870
🔧 Dropdown.Fluent 3.2 0.43 7.44:1 1000 3196
🔧 Icon.Fluent 0.15 0.07 2.14:1 5000 749
🦄 Image.Fluent 0.09 0.13 0.69:1 5000 468
🔧 Slider.Fluent 1.63 0.47 3.47:1 1000 1633
🔧 Text.Fluent 0.09 0.03 3:1 5000 437
🦄 Tooltip.Fluent 0.12 0.91 0.13:1 5000 611

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonSlotsPerf.default 634 581 1.09:1
CarouselMinimalPerf.default 551 505 1.09:1
VideoMinimalPerf.default 748 694 1.08:1
Text.Fluent 437 405 1.08:1
TextAreaMinimalPerf.default 598 561 1.07:1
SegmentMinimalPerf.default 420 398 1.06:1
StatusMinimalPerf.default 849 799 1.06:1
ButtonMinimalPerf.default 221 211 1.05:1
DividerMinimalPerf.default 440 421 1.05:1
DialogMinimalPerf.default 884 848 1.04:1
DropdownManyItemsPerf.default 798 770 1.04:1
FlexMinimalPerf.default 359 344 1.04:1
ListMinimalPerf.default 595 573 1.04:1
TooltipMinimalPerf.default 899 867 1.04:1
Avatar.Fluent 385 370 1.04:1
AttachmentSlotsPerf.default 1321 1287 1.03:1
ChatMinimalPerf.default 716 697 1.03:1
HeaderSlotsPerf.default 923 900 1.03:1
ListNestedPerf.default 652 636 1.03:1
SkeletonMinimalPerf.default 452 440 1.03:1
Tooltip.Fluent 611 591 1.03:1
AlertMinimalPerf.default 347 341 1.02:1
AttachmentMinimalPerf.default 186 182 1.02:1
FormMinimalPerf.default 502 490 1.02:1
LoaderMinimalPerf.default 774 760 1.02:1
MenuButtonMinimalPerf.default 1689 1661 1.02:1
PortalMinimalPerf.default 173 169 1.02:1
RadioGroupMinimalPerf.default 531 519 1.02:1
SplitButtonMinimalPerf.default 4108 4038 1.02:1
TreeMinimalPerf.default 871 857 1.02:1
TreeWith60ListItems.default 201 198 1.02:1
AnimationMinimalPerf.default 438 433 1.01:1
ChatDuplicateMessagesPerf.default 399 397 1.01:1
ChatWithPopoverPerf.default 487 482 1.01:1
LayoutMinimalPerf.default 463 460 1.01:1
PopupMinimalPerf.default 752 741 1.01:1
TableManyItemsPerf.default 2273 2256 1.01:1
Checkbox.Fluent 677 673 1.01:1
Image.Fluent 468 462 1.01:1
ButtonOverridesMissPerf.default 1785 1778 1:1
ButtonUseCssNestingPerf.default 1137 1137 1:1
CardMinimalPerf.default 635 633 1:1
DatepickerMinimalPerf.default 49178 49290 1:1
EmbedMinimalPerf.default 4421 4403 1:1
ImageMinimalPerf.default 447 446 1:1
LabelMinimalPerf.default 483 481 1:1
ProviderMinimalPerf.default 1027 1031 1:1
RefMinimalPerf.default 244 244 1:1
SliderMinimalPerf.default 1672 1677 1:1
TableMinimalPerf.default 448 449 1:1
TextMinimalPerf.default 409 410 1:1
Dropdown.Fluent 3196 3186 1:1
Icon.Fluent 749 746 1:1
AvatarMinimalPerf.default 227 229 0.99:1
DropdownMinimalPerf.default 3082 3113 0.99:1
GridMinimalPerf.default 420 425 0.99:1
InputMinimalPerf.default 1365 1379 0.99:1
ListWith60ListItems.default 672 681 0.99:1
MenuMinimalPerf.default 949 962 0.99:1
ReactionMinimalPerf.default 468 475 0.99:1
ToolbarMinimalPerf.default 1056 1066 0.99:1
ButtonUseCssPerf.default 886 902 0.98:1
CheckboxMinimalPerf.default 2931 2987 0.98:1
HeaderMinimalPerf.default 439 448 0.98:1
ItemLayoutMinimalPerf.default 1365 1390 0.98:1
ListCommonPerf.default 735 748 0.98:1
ProviderMergeThemesPerf.default 1595 1625 0.98:1
IconMinimalPerf.default 716 727 0.98:1
Button.Fluent 645 658 0.98:1
CustomToolbarPrototype.default 3818 3945 0.97:1
Slider.Fluent 1633 1677 0.97:1
Dialog.Fluent 870 909 0.96:1
RosterPerf.default 1275 1345 0.95:1
AccordionMinimalPerf.default 171 187 0.91:1
BoxMinimalPerf.default 418 475 0.88:1

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that you'll need to cherry-pick this to the 7.0 branch to get it to show up on the website right away. https://github.com/microsoft/fluentui/wiki/Contributing-to-the-7.0-branch

@ecraig12345 ecraig12345 merged commit e5800d7 into microsoft:master Feb 13, 2021
@markavitale markavitale mentioned this pull request Feb 15, 2021
2 tasks
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/public-docsite@v8.0.0-beta.2 has been released which incorporates this pull request.:tada:

Handy links:

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants