Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apple links in 7.0 #16987

Merged
merged 2 commits into from
Feb 16, 2021

Conversation

markavitale
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

The fluentui-apple repository recently updated its default branch to be named 'main'. Since there are some links to the old default branch ('master') in our documentation, update them to be correct. There were a few other minor changes due to some refactoring in the fluentui-apple repository.

Note this was already merged into master with #16978, this is a cherry-pick to the 7.0 branch to update the current website.

Focus areas to test

Ensure the links properly take users to the new default branch of the Microsoft/fluentui-apple GitHub repository. Tested by running the website locally and clicking through the links.

@msft-fluent-ui-bot msft-fluent-ui-bot added the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 15, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a0770f4:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration

@size-auditor
Copy link

size-auditor bot commented Feb 15, 2021

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 974bfc7

Possible causes

  • The baseline build 974bfc7 is broken
  • The Size Auditor run for the baseline build 974bfc7 was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type 7.0 Ticks PR Ticks Iterations Status
BaseButton mount 1813 1349 5000
Breadcrumb mount 47865 48219 5000
Checkbox mount 1780 2228 5000
CheckboxBase mount 1485 1555 5000
ChoiceGroup mount 5656 5947 5000
ComboBox mount 1175 2021 1000
CommandBar mount 9628 9641 1000
ContextualMenu mount 16570 16610 1000
DefaultButton mount 1487 1468 5000
DetailsRow mount 4609 4513 5000
DetailsRowFast mount 4611 4250 5000
DetailsRowNoStyles mount 4351 4353 5000
Dialog mount 1777 1748 1000
DocumentCardTitle mount 2197 1993 1000
Dropdown mount 3095 3138 5000
FocusTrapZone mount 2188 2095 5000
FocusZone mount 2062 2128 5000
IconButton mount 2454 2251 5000
Label mount 401 404 5000
Layer mount 2536 2273 5000
Link mount 505 537 5000
MenuButton mount 1828 1716 5000
MessageBar mount 2311 2391 5000
Nav mount 4115 3801 1000
OverflowSet mount 1796 1682 5000
Panel mount 1733 1691 1000
Persona mount 1019 943 1000
Pivot mount 1635 1609 1000
PrimaryButton mount 1446 1683 5000
Rating mount 9252 9129 5000
SearchBox mount 1611 1671 5000
Shimmer mount 3180 3139 5000
Slider mount 1758 1851 5000
SpinButton mount 6059 6259 5000
Spinner mount 494 472 5000
SplitButton mount 4311 3868 5000
Stack mount 617 628 5000
StackWithIntrinsicChildren mount 1648 1740 5000
StackWithTextChildren mount 5464 5814 5000
SwatchColorPicker mount 11934 11993 5000
TagPicker mount 3251 3117 5000
TeachingBubble mount 57944 57578 5000
Text mount 536 671 5000
TextField mount 1676 1668 5000
Toggle mount 1016 972 5000
button mount 109 131 5000

@ecraig12345 ecraig12345 removed the needs cherry-pick Temporary label for PRs which may need to be cherry-picked to master label Feb 16, 2021
@ecraig12345 ecraig12345 merged commit fb40578 into microsoft:7.0 Feb 16, 2021
@markavitale markavitale deleted the cherry-pick-apple-links branch February 16, 2021 20:00
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@uifabric/fabric-website@v7.16.28 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants