ContextualMenu: focused div when menu is opened now has role = "menu" #17683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changes
Baseline commit: 8d233d903ed4622fa6537bb300f90f740cfd52b7 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7605487:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
reviewed
Apr 2, 2021
packages/react/src/components/ContextualMenu/ContextualMenu.base.tsx
Outdated
Show resolved
Hide resolved
khmakoto
approved these changes
Apr 7, 2021
smhigley
approved these changes
Apr 8, 2021
joschect
approved these changes
Apr 9, 2021
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
2 tasks
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…microsoft#17683) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#17628 - [x] Include a change request file using `$ yarn change` #### Description of changes ContextualMenu: element that's focused when menu is opened now has role = "menu" - Moved `role = menu`, `aria-label` and `aria-labelledby` attributes to container div which is the element that gains focus when menu is opened. - Updated all elements in between container div and first menu item to have `role = presentation`. - Updated Button tests to account for role changes as element with attributes `role='menu'`, `aria-label` and `aria-labelledby` were moved from `onRenderMenuList` to the container div. - Removed 1 `onRenderMenuList` unit test from `ContextualMenu` since `role` will be static as `"presentation"` moving forward.
2 tasks
rzhouac
pushed a commit
to rzhouac/fluentui
that referenced
this pull request
Jun 1, 2021
…microsoft#17683) - [x] Addresses an existing issue: Fixes microsoft#17628 - [x] Include a change request file using `$ yarn change` ContextualMenu: element that's focused when menu is opened now has role = "menu" - Moved `role = menu`, `aria-label` and `aria-labelledby` attributes to container div which is the element that gains focus when menu is opened. - Updated all elements in between container div and first menu item to have `role = presentation`. - Updated Button tests to account for role changes as element with attributes `role='menu'`, `aria-label` and `aria-labelledby` were moved from `onRenderMenuList` to the container div. - Removed 1 `onRenderMenuList` unit test from `ContextualMenu` since `role` will be static as `"presentation"` moving forward.
2 tasks
msft-fluent-ui-bot
pushed a commit
that referenced
this pull request
Jun 3, 2021
#### Pull request checklist - [x] Addresses an existing issue: Fixes #17628 https://dev.azure.com/microsoftdesign/fluent-ui/_workitems/edit/10740 - [x] Include a change request file using `$ yarn change` #### Description of changes (give an overview) #### Focus areas to test contextual menu with nexted section (optional) Cherry pick of #17628 & #17683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
ContextualMenu: element that's focused when menu is opened now has role = "menu"
role = menu,aria-labelandaria-labelledbyattributes to container div which is the element that gains focus when menu is opened.role = presentation.role='menu',aria-labelandaria-labelledbywere moved fromonRenderMenuListto the container div.onRenderMenuListunit test fromContextualMenusincerolewill be static as"presentation"moving forward.