CherryPick #17628 & 17683, fix contextual menu hierarchy issue #18389
Conversation
msft-fluent-ui-bot
added
the
needs cherry-pick
msft-fluent-ui-bot
left a comment
msft-fluent-ui-bot
left a comment
There was a problem hiding this comment.
It looks like this change to the 7.0 branch may not have been submitted to master yet. Now that version 8 has released, all changes must be submitted to the master branch first (except in emergencies or if the change is irrelevant to version 8).
Please do one of the following:
- If you've already created a PR to
master, add a link to it - If the change is irrelevant to version 8, add a comment explaining why
- Otherwise, create a PR to
masterwith this same change, and add a link to it
After that, you can dismiss this review and remove the "needs cherry-pick" label (or ask a team member to help do so).
Want to avoid this in the future? Include text like "Cherry-pick of ####" in the PR description (where #### is the real master PR number).
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d4a77bd:
|
…microsoft#17683) - [x] Addresses an existing issue: Fixes microsoft#17628 - [x] Include a change request file using `$ yarn change` ContextualMenu: element that's focused when menu is opened now has role = "menu" - Moved `role = menu`, `aria-label` and `aria-labelledby` attributes to container div which is the element that gains focus when menu is opened. - Updated all elements in between container div and first menu item to have `role = presentation`. - Updated Button tests to account for role changes as element with attributes `role='menu'`, `aria-label` and `aria-labelledby` were moved from `onRenderMenuList` to the container div. - Removed 1 `onRenderMenuList` unit test from `ContextualMenu` since `role` will be static as `"presentation"` moving forward.
|
this PR cherry picked these two prs:
@smhigley @TristanWatanabe can you take a look at this PR? |
Asset size changes
Baseline commit: 70f4285a51c2c47d6ac79019810568636f69e5a2 (build) |
Perf AnalysisNo significant results to display. All results
|
rzhouac
changed the title
rzhouac
changed the title
khmakoto
dismissed
msft-fluent-ui-bot’s stale review
This is a cherry-pick of a PR in master.
ecraig12345
removed
the
needs cherry-pick
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
|
🎉 Handy links: |
7 participants
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
contextual menu with nexted section
(optional)
Cherry pick of #17628 & #17683