fix: Table row height is determined by cells #25717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Table rows no longer determine the row height. The height styles are set of each table cell. This allows for better flexibility and fixes a bug where table header cell height should be different from other cells. Addresses microsoft#25706
16 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d2a957c632af5cc995b4582a3b8e8f075139df7b (build) |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1264 | 1266 | 5000 | |
| Button | mount | 929 | 904 | 5000 | |
| FluentProvider | mount | 1475 | 1510 | 5000 | |
| FluentProviderWithTheme | mount | 595 | 572 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 536 | 547 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 582 | 573 | 10 | |
| MakeStyles | mount | 1957 | 1940 | 50000 | |
| SpinButton | mount | 2367 | 2327 | 5000 |
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 146 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1605 screenshots unchanged, 0 screenshots with different dimensions and 146 screenshots with visible difference. unknown 146 screenshots
|
miroslavstastny
approved these changes
Nov 21, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
* fix: Table row height is determined by cells Table rows no longer determine the row height. The height styles are set of each table cell. This allows for better flexibility and fixes a bug where table header cell height should be different from other cells. Addresses microsoft#25706 * changefile * update md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table rows no longer determine the row height. The height styles are set of each table cell. This is actually necessary for flex layout so that the cells aren't smaller than the row.
Also fixes a bug where the header should have height 32px
Before
After
Addresses #25706