-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Component CSS Transitions/Animations on mount/unmount #27328
RFC: Component CSS Transitions/Animations on mount/unmount #27328
Conversation
📊 Bundle size report🤖 This report was generated against afcfb2ebe322e2a8e204ac192e68f48f1164107f |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 17f0406:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 64fec9dade3f8c033b05332207c33479c26bacb4 (build) |
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
@spmonahan will review from @microsoft/cxe-red |
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
…nt-or-unmount.md Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
…nt-or-unmount.md Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
rfcs/react-components/convergence/component-transitions-on-mount-or-unmount.md
Outdated
Show resolved
Hide resolved
* master: (27 commits) feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) applying package updates bugfix: ensure interop between assertSlots and old API (microsoft#28957) chore: rename imports from react-tree to react-components (microsoft#28946) applying package updates fix: Autofill queries the inputElement ownerDocument instead of document (microsoft#27312) Accordion : updated styles for accordion header cursor (microsoft#28850) Additional VR tests Charting Library (microsoft#28777) feat(react-motion): create react-motion-preview package scaffolding (microsoft#28947) chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) ...
…e-motion * feat/use-motion-presence-hook: (25 commits) fix: revert changes to CODEOWNERS fix: remove duplicated code due to a merge conflict fix: upgrade tests fix: set motion as active when animations are disabled fix: remove debug function feat: refactor useMotion to a much more clean/performant logic fix: use correct type for MotionOptions fix: improve typings and documentation feat: Add documentKeyboardEvent to OnVisibleChangeData when Tooltip is hidden via Escape (microsoft#28951) fix: use correct boolean values RFC: Component CSS Transitions/Animations on mount/unmount (microsoft#27328) 8.0 Azure Theme: Details list row focus contrast a11y bug fix (microsoft#28966) fix: remove outdated changefile chore: update CODEOWNERS to some components to tag the current owner (microsoft#28949) fix(react-popover): Only apply modal attributes if the PopoverSurface traps focus (microsoft#28613) feat(react-table, react-components): export DataGridContextProvider (microsoft#28955) chore: decrease bundle size & adds fixtures (microsoft#28962) feat(react-utilities): create useAnimationFrame hook (microsoft#28948) fix(react-utilities): `useOnClickOutside` should consider text selection from inside to outside as inside click (microsoft#28765) docs(react-accordion): Added subcomponents to index story (microsoft#28956) ...
RFC to add support for CSS Animation and Transition to mount/unmount of elements. Please refer to the RFC document this PR creates.
A full implementation and live examples of this approach can be found here:
Drawer motion