-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: Modify Image Web Component Styles #27567
Update: Modify Image Web Component Styles #27567
Conversation
…e that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius.
…spec. Updates attribute descriptions in the story.
📊 Bundle size report🤖 This report was generated against bdb9124866e9a0c64b5a609826a9178c18e7e1ad |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bdb9124866e9a0c64b5a609826a9178c18e7e1ad (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dffcee3:
|
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
* Updates story with better placeholder images. Updates styles to ensure that shadow, shape and border work correctly when fit is center. Sets default border-radius and updates storybook shape description with detail about the default border radius. * Yarn change * Reverts style changes. Adds only essential style adjustments to meet spec. Updates attribute descriptions in the story. * Removes pixel value in description for design token: borderRadiusMedium.
Updates story with better placeholder images. Sets default border-radius and updates shape param description in the story with detail about the default border radius and available values to choose from when implementing.
Please verify that:
web-components-v3
branchyarn change
locallyPrevious Behavior
When shape: rounded is selected, no border-radius is applied.
shape param description in the story does not provide the developer with border-radius implementation details.
New Behavior
Border radius styles were added, using the 4px default value for when shape: rounded is selected.
The shape: rounded description in the story now has implementation details for the developer.
Related Issue(s)