Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme designer v9 #27861

Merged
merged 123 commits into from
May 22, 2023
Merged

Theme designer v9 #27861

merged 123 commits into from
May 22, 2023

Conversation

timbellay
Copy link
Contributor

Previous Behavior

  • N/A, adding some cleanup items for Fluent V9

New Behavior

  • Collapsed app state into single state with reducer. Fixed infinite state updating bug.
  • Simplified flow of app using the left nav and steps for user to generate palette.
  • Updated sticker sheet to show missing v9 components
  • Created a test object and a test system for future tests and clarity of test results.
  • Reduced contrast tests to handle the main two tests only: colorBrandForeground1: ['colorNeutralBackground1', 4.5] and colorBrandForeground2: ['colorBrandBackground2', 4.5] for simplicity.
  • Added contrast ratios to dropdown in the token selection menu of failed tests so users can know the effect of changing a token value on the test.
  • Change curve snapping points from [0, 50, 100] to [start, middle, end] based on Arman's spec and hard coded this in hueToSnappingPointsMap.
  • Use brand[110] instead of brand[100] and brand[120] instead of brand[110] for dark theming per guidelines
  • Minor GUI improvements

Related Issue(s)

timbellay and others added 30 commits March 21, 2023 11:38
@timbellay
Test of pipeline.
d6d0b9c
@timbellay
Merge branch 'master' of https://github.com/ms-acalzaretto/fluentui i…
61e1c25 
…nto tim
@timbellay
Fix unessesary debounce complications.
5d4f307
@timbellay
rem logs.
b06ffdd
@timbellay
Expand copy hex to full color div.
11ac5cd
@ms-acalzaretto
First batch of refactoring the state-store
d6a994d
@timbellay
Clean up left nav.
9adce5b
@ms-acalzaretto
More refactoring
7f49a1d
@timbellay
merge to dev
ecbfbf8
@ms-acalzaretto
Dark theme fixes
7f1051d
@ms-acalzaretto
Merge branch 'state-store-refactor' of https://github.com/ms-acalzare…
fb8b35f 
…tto/fluentui into state-store-refactor
@ms-acalzaretto
More polishing
718a6be
@timbellay
Fix export link and themeName.
ec14413
@timbellay
Merge branch 'state-store-refactor' of https://github.com/ms-acalzare…
54458b0 
…tto/fluentui into state-store-refactor
@ms-acalzaretto
Contet fixes
eea0122
@ms-acalzaretto
Merge branch 'state-store-refactor' into theme-designer-v9
040f297
@ms-acalzaretto
Merge branch 'master' into theme-designer-v9
b976cb0
@ms-acalzaretto
Bug fixes
3f5cc80
@timbellay
Move export to Form and make a Panel.
ec84eeb
@timbellay
Lint exceptions.
8c17fd0
@ms-acalzaretto
Removed most of header
b50f9b0
@ms-acalzaretto
Merge branch 'theme-designer-v9' of https://github.com/ms-acalzaretto…
24a083b 
…/fluentui into theme-designer-v9
@ms-acalzaretto
Added debounce for keycolor
b83a20e
@ms-acalzaretto
Added key color banner
76ab673
@ms-acalzaretto
Fixed linting issues
7af1f44
@timbellay
Fix build.
933fec5
@timbellay
Merge branch 'theme-designer-v9' of https://github.com/ms-acalzaretto…
ff0ad5d 
…/fluentui into theme-designer-v9
@ms-acalzaretto
Added title & description
15a7df9
@ms-acalzaretto
Merge branch 'theme-designer-v9' of https://github.com/ms-acalzaretto…
8040e65 
…/fluentui into theme-designer-v9
@ms-acalzaretto
Cleaned up nav for input
8b27385
@TristanWatanabe
Copy link
Member

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TristanWatanabe
Copy link
Member

/azp run Fluent UI React - PR and CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sopranopillow
sopranopillow approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@sopranopillow sopranopillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly minor comments, I would say the sticker ones are needed since those are exposed to the user. The Designer looks great!!!

packages/react-components/theme-designer/src/components/Demo/Demo.tsx Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Demo/Demo.tsx Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Demo/Demo.tsx Show resolved Hide resolved
packages/react-components/theme-designer/src/ThemeDesigner.tsx Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/ColorTokens/TokenList.style.ts Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Demo/Demo.tsx Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Export/ExportPanel.tsx Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Header/Header.stories.tsx Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Sidebar/Form.tsx Outdated Show resolved Hide resolved
packages/react-components/theme-designer/src/components/Sidebar/Form.tsx Outdated Show resolved Hide resolved
@sopranopillow
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@sopranopillow sopranopillow enabled auto-merge (squash) May 19, 2023 19:58
@sopranopillow sopranopillow reopened this May 22, 2023
@micahgodbolt micahgodbolt merged commit 0cc88f2 into microsoft:master May 22, 2023
27 checks passed
@Hotell Hotell mentioned this pull request Jun 7, 2023
Closed
2 tasks
@TristanWatanabe TristanWatanabe mentioned this pull request Dec 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopranopillow sopranopillow sopranopillow approved these changes

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@ms-acalzaretto ms-acalzaretto ms-acalzaretto approved these changes

Assignees

@TristanWatanabe TristanWatanabe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@timbellay @fabricteam @TristanWatanabe @sopranopillow @ms-acalzaretto @micahgodbolt