-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web-components-v3): migrate to node 18 #30026
Merged
TristanWatanabe
merged 14 commits into
microsoft:web-components-v3
from
TristanWatanabe:tristan/node-18-upgrade
Dec 13, 2023
Merged
chore(web-components-v3): migrate to node 18 #30026
TristanWatanabe
merged 14 commits into
microsoft:web-components-v3
from
TristanWatanabe:tristan/node-18-upgrade
Dec 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles
…#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change
* add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com>
* move colors code locally to allow for customization * clean up files
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c7f37de:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8e4b69e7ef0e9f73b9613c85c2891470217affcc (build) |
…nes::unsupported' webpack error within local-sandbox
fabricteam
reviewed
Dec 7, 2023
TristanWatanabe
commented
Dec 8, 2023
packages/react-components/theme-designer/src/components/Sidebar/Sidebar.tsx
Show resolved
Hide resolved
chrisdholt
approved these changes
Dec 11, 2023
tudorpopams
approved these changes
Dec 12, 2023
miroslavstastny
approved these changes
Dec 13, 2023
spmonahan
approved these changes
Dec 13, 2023
packages/react-components/theme-designer/src/components/Sidebar/Sidebar.tsx
Show resolved
Hide resolved
TristanWatanabe
merged commit Dec 13, 2023
12da476
into
microsoft:web-components-v3
38 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore: migrate to node 18 (#29598) * chore: migrate to node 18 * chore: bump eslint-plugin-jsdoc which support node 18 * generate changefile * chore: ignore plugin-jsdoc from syncpack * chore(utilities): use Timers types based on environment to avoid TS failures introduced with node 18 types * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * generate changefiles * restrict node version * update yarn.lock * ci: bump devcontainer to node 18 (#29759) * deduplicate semver * theme designers: changes based on dan and daisy's feedback (#24038) * for daisy: Can the default theme be the Web one (not Teams)? Web should be the first one selected by default. Teams is one option in the menu. * suggestion from dan: when he inputted his own custom Hex#, the color indicator to the right didn't change -- added rules to hex input * remove teams theme * capitalize for consistency * custom theme now applies to sidebar per dan's request * uppercase consistency * revert sidebar change * theme designer: make name editable (#24098) * add dropdown * Update yarn.lock * cleanup dropdown use * lock update * remove unread values * use dropdown + add avatar * add editable name * palette change * force alphanumeric * filter input name string * update name * revert palette change Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com> * Theme designer: Move colors to local files (#27191) * move colors code locally to allow for customization * clean up files * deduplicate prettier * fix: UseNode@1 instead of NodeTool * format files * chore: bump babel-loader to mitigate '0308010c:digital envelope routines::unsupported' webpack error within local-sandbox * update yarn.lock * chore: comment out unused codeblock to fix TS transpile errors --------- Co-authored-by: Martin Hochel <martinhochel@microsoft.com> Co-authored-by: Emma Jiang <31319479+emmayjiang@users.noreply.github.com> Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
master
branch to get pipelines passing.@fluentui/theme-designer
related PRs cherry-picked as this package caused the most issues during migration@fluentui/theme-designer
included an overhaul(Theme designer v9 #27861) which used new v9 imports which aren't in this branch so I didn't want to cherry-pick that as well.