Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix listbox-option selected indicator position in rtl #27894

Merged

Conversation

chrisdholt
Copy link
Member

Previous Behavior

The indicator did not localize correctly

New Behavior

The indicator localizes as expected

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented May 18, 2023

📊 Bundle size report

🤖 This report was generated against 93fe951af53331b1effdf3b24dab4e1f6f57aa83

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1933019:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented May 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 23d7cf2e10bee1978b3345a4a6d4b76a651a28e4 (build)

@vnbaaij
Copy link
Contributor

vnbaaij commented May 31, 2023

@microsoft/fui-wc can we get this merged in?

@chrisdholt chrisdholt merged commit 629df3c into microsoft:master May 31, 2023
26 checks passed
@chrisdholt chrisdholt deleted the users/chhol/fix-selected-indicator-rtl branch May 31, 2023 19:04
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v2.5.15 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants