Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(fluent-button): Add screenshot tests #28797

Merged
merged 2 commits into from
Aug 21, 2023
Merged

chore(fluent-button): Add screenshot tests #28797

merged 2 commits into from
Aug 21, 2023

Conversation

miroslavstastny
Copy link
Member

Add screenshot tests for fluent-button

@miroslavstastny miroslavstastny requested a review from a team as a code owner August 9, 2023 20:14
@miroslavstastny miroslavstastny added the Fluent UI WC (v3) Fluent UI Web Component V3 label Aug 9, 2023
@miroslavstastny miroslavstastny self-assigned this Aug 9, 2023
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 9, 2023
@miroslavstastny miroslavstastny mentioned this pull request Aug 9, 2023
Closed
21 tasks
fabricteam
fabricteam reviewed Aug 9, 2023
View reviewed changes
apps/vr-tests-web-components/src/stories/button/button.stories.tsx
@@ -0,0 +1,147 @@
import * as React from 'react';
Copy link
Collaborator

@fabricteam fabricteam Aug 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots

Button 144 screenshots
Image Name Diff(in Pixels) Image Type
Button.Circular.default.chromium.png 0 Added
Button.Circular.hover.chromium.png 0 Added
Button.Circular.pressed.chromium.png 0 Added
Button.Default.default.chromium.png 0 Added
Button.Default.hover.chromium.png 0 Added
Button.Default.pressed.chromium.png 0 Added
Button.Large Icon Only - Dark Mode.default.chromium.png 0 Added
Button.Large Icon Only - Dark Mode.hover.chromium.png 0 Added
Button.Large Icon Only - Dark Mode.pressed.chromium.png 0 Added
Button.Large Icon Only.default.chromium.png 0 Added
Button.Large Icon Only.hover.chromium.png 0 Added
Button.Large Icon Only.pressed.chromium.png 0 Added
Button.Large With Icon - Dark Mode.default.chromium.png 0 Added
Button.Large With Icon - Dark Mode.hover.chromium.png 0 Added
Button.Large With Icon - Dark Mode.pressed.chromium.png 0 Added
Button.Large With Icon - RTL.default.chromium.png 0 Added
Button.Large With Icon - RTL.hover.chromium.png 0 Added
Button.Large With Icon - RTL.pressed.chromium.png 0 Added
Button.Large With Icon.default.chromium.png 0 Added
Button.Large With Icon.hover.chromium.png 0 Added
Button.Large With Icon.pressed.chromium.png 0 Added
Button.Large.default.chromium.png 0 Added
Button.Large.hover.chromium.png 0 Added
Button.Large.pressed.chromium.png 0 Added
Button.Medium Icon Only - Dark Mode.default.chromium.png 0 Added
Button.Medium Icon Only - Dark Mode.hover.chromium.png 0 Added
Button.Medium Icon Only - Dark Mode.pressed.chromium.png 0 Added
Button.Medium Icon Only.default.chromium.png 0 Added
Button.Medium Icon Only.hover.chromium.png 0 Added
Button.Medium Icon Only.pressed.chromium.png 0 Added
Button.Medium With Icon - Dark Mode.default.chromium.png 0 Added
Button.Medium With Icon - Dark Mode.hover.chromium.png 0 Added
Button.Medium With Icon - Dark Mode.pressed.chromium.png 0 Added
Button.Medium With Icon - RTL.default.chromium.png 0 Added
Button.Medium With Icon - RTL.hover.chromium.png 0 Added
Button.Medium With Icon - RTL.pressed.chromium.png 0 Added
Button.Medium With Icon.default.chromium.png 0 Added
Button.Medium With Icon.hover.chromium.png 0 Added
Button.Medium With Icon.pressed.chromium.png 0 Added
Button.Medium.default.chromium.png 0 Added
Button.Medium.hover.chromium.png 0 Added
Button.Medium.pressed.chromium.png 0 Added
Button.Outline - Dark Mode.default.chromium.png 0 Added
Button.Outline - Dark Mode.hover.chromium.png 0 Added
Button.Outline - Dark Mode.pressed.chromium.png 0 Added
Button.Outline Disabled - Dark Mode.default.chromium.png 0 Added
Button.Outline Disabled - Dark Mode.hover.chromium.png 0 Added
Button.Outline Disabled - Dark Mode.pressed.chromium.png 0 Added
Button.Outline Disabled Focusable - Dark Mode.default.chromium.png 0 Added
Button.Outline Disabled Focusable - Dark Mode.hover.chromium.png 0 Added
Button.Outline Disabled Focusable - Dark Mode.pressed.chromium.png 0 Added
Button.Outline Disabled Focusable.default.chromium.png 0 Added
Button.Outline Disabled Focusable.hover.chromium.png 0 Added
Button.Outline Disabled Focusable.pressed.chromium.png 0 Added
Button.Outline Disabled.default.chromium.png 0 Added
Button.Outline Disabled.hover.chromium.png 0 Added
Button.Outline Disabled.pressed.chromium.png 0 Added
Button.Outline.default.chromium.png 0 Added
Button.Outline.hover.chromium.png 0 Added
Button.Outline.pressed.chromium.png 0 Added
Button.Primary - Dark Mode.default.chromium.png 0 Added
Button.Primary - Dark Mode.hover.chromium.png 0 Added
Button.Primary - Dark Mode.pressed.chromium.png 0 Added
Button.Primary Disabled - Dark Mode.default.chromium.png 0 Added
Button.Primary Disabled - Dark Mode.hover.chromium.png 0 Added
Button.Primary Disabled - Dark Mode.pressed.chromium.png 0 Added
Button.Primary Disabled Focusable - Dark Mode.default.chromium.png 0 Added
Button.Primary Disabled Focusable - Dark Mode.hover.chromium.png 0 Added
Button.Primary Disabled Focusable - Dark Mode.pressed.chromium.png 0 Added
Button.Primary Disabled Focusable.default.chromium.png 0 Added
Button.Primary Disabled Focusable.hover.chromium.png 0 Added
Button.Primary Disabled Focusable.pressed.chromium.png 0 Added
Button.Primary Disabled.default.chromium.png 0 Added
Button.Primary Disabled.hover.chromium.png 0 Added
Button.Primary Disabled.pressed.chromium.png 0 Added
Button.Primary.default.chromium.png 0 Added
Button.Primary.hover.chromium.png 0 Added
Button.Primary.pressed.chromium.png 0 Added
Button.Rounded.default.chromium.png 0 Added
Button.Rounded.hover.chromium.png 0 Added
Button.Rounded.pressed.chromium.png 0 Added
Button.Small Icon Only - Dark Mode.default.chromium.png 0 Added
Button.Small Icon Only - Dark Mode.hover.chromium.png 0 Added
Button.Small Icon Only - Dark Mode.pressed.chromium.png 0 Added
Button.Small Icon Only.default.chromium.png 0 Added
Button.Small Icon Only.hover.chromium.png 0 Added
Button.Small Icon Only.pressed.chromium.png 0 Added
Button.Small With Icon - Dark Mode.default.chromium.png 0 Added
Button.Small With Icon - Dark Mode.hover.chromium.png 0 Added
Button.Small With Icon - Dark Mode.pressed.chromium.png 0 Added
Button.Small With Icon - RTL.default.chromium.png 0 Added
Button.Small With Icon - RTL.hover.chromium.png 0 Added
Button.Small With Icon - RTL.pressed.chromium.png 0 Added
Button.Small With Icon.default.chromium.png 0 Added
Button.Small With Icon.hover.chromium.png 0 Added
Button.Small With Icon.pressed.chromium.png 0 Added
Button.Small.default.chromium.png 0 Added
Button.Small.hover.chromium.png 0 Added
Button.Small.pressed.chromium.png 0 Added
Button.Square.default.chromium.png 0 Added
Button.Square.hover.chromium.png 0 Added
Button.Square.pressed.chromium.png 0 Added
Button.Subtle - Dark Mode.default.chromium.png 0 Added
Button.Subtle - Dark Mode.hover.chromium.png 0 Added
Button.Subtle - Dark Mode.pressed.chromium.png 0 Added
Button.Subtle Disabled - Dark Mode.default.chromium.png 0 Added
Button.Subtle Disabled - Dark Mode.hover.chromium.png 0 Added
Button.Subtle Disabled - Dark Mode.pressed.chromium.png 0 Added
Button.Subtle Disabled Focusable - Dark Mode.default.chromium.png 0 Added
Button.Subtle Disabled Focusable - Dark Mode.hover.chromium.png 0 Added
Button.Subtle Disabled Focusable - Dark Mode.pressed.chromium.png 0 Added
Button.Subtle Disabled Focusable.default.chromium.png 0 Added
Button.Subtle Disabled Focusable.hover.chromium.png 0 Added
Button.Subtle Disabled Focusable.pressed.chromium.png 0 Added
Button.Subtle Disabled.default.chromium.png 0 Added
Button.Subtle Disabled.hover.chromium.png 0 Added
Button.Subtle Disabled.pressed.chromium.png 0 Added
Button.Subtle.default.chromium.png 0 Added
Button.Subtle.hover.chromium.png 0 Added
Button.Subtle.pressed.chromium.png 0 Added
Button.Transparent - Dark Mode.default.chromium.png 0 Added
Button.Transparent - Dark Mode.hover.chromium.png 0 Added
Button.Transparent - Dark Mode.pressed.chromium.png 0 Added
Button.Transparent Disabled - Dark Mode.default.chromium.png 0 Added
Button.Transparent Disabled - Dark Mode.hover.chromium.png 0 Added
Button.Transparent Disabled - Dark Mode.pressed.chromium.png 0 Added
Button.Transparent Disabled Focusable - Dark Mode.default.chromium.png 0 Added
Button.Transparent Disabled Focusable - Dark Mode.hover.chromium.png 0 Added
Button.Transparent Disabled Focusable - Dark Mode.pressed.chromium.png 0 Added
Button.Transparent Disabled Focusable.default.chromium.png 0 Added
Button.Transparent Disabled Focusable.hover.chromium.png 0 Added
Button.Transparent Disabled Focusable.pressed.chromium.png 0 Added
Button.Transparent Disabled.default.chromium.png 0 Added
Button.Transparent Disabled.hover.chromium.png 0 Added
Button.Transparent Disabled.pressed.chromium.png 0 Added
Button.Transparent.default.chromium.png 0 Added
Button.Transparent.hover.chromium.png 0 Added
Button.Transparent.pressed.chromium.png 0 Added
Button.With Long Text - RTL.default.chromium.png 0 Added
Button.With Long Text - RTL.hover.chromium.png 0 Added
Button.With Long Text - RTL.pressed.chromium.png 0 Added
Button.With Long Text.default.chromium.png 0 Added
Button.With Long Text.hover.chromium.png 0 Added
Button.With Long Text.pressed.chromium.png 0 Added

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 9, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 4cdb75f551ad5920e5184b6bdfd7585d64026c18

@size-auditor
Copy link

size-auditor bot commented Aug 9, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 46f65d10bedb042fd79a23c537bf7856fb38b497 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 9, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 103eed7:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@miroslavstastny miroslavstastny enabled auto-merge (squash) August 9, 2023 21:18
@miroslavstastny miroslavstastny merged commit 587a518 into microsoft:web-components-v3 Aug 21, 2023
19 checks passed
@miroslavstastny miroslavstastny deleted the chore/vr-button branch August 21, 2023 19:45
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
@miroslavstastny @chrisdholt
chore(button): Add screenshot tests (#28797)
e8c1759
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (microsoft#28797)
9935e7a
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (microsoft#28797)
a64bc86
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (microsoft#28797)
0573c78
radium-v pushed a commit that referenced this pull request Apr 30, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
2f2d884
radium-v pushed a commit that referenced this pull request May 2, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
188a07b
radium-v pushed a commit that referenced this pull request May 2, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
1bc10c7
radium-v pushed a commit that referenced this pull request May 2, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
d3e336d
radium-v pushed a commit that referenced this pull request May 3, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
820346e
radium-v pushed a commit that referenced this pull request May 6, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
a0bf1a8
radium-v pushed a commit that referenced this pull request May 6, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
5f90339
radium-v pushed a commit that referenced this pull request May 8, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
796acd5
radium-v pushed a commit that referenced this pull request May 10, 2024
@miroslavstastny @radium-v
chore(button): Add screenshot tests (#28797)
0a53bac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

Assignees

@miroslavstastny miroslavstastny

Labels
Fluent UI WC (v3) Fluent UI Web Component V3
Projects
None yet
Milestone
August Project Cycle Q4 2023
Development

Successfully merging this pull request may close these issues.
2 participants
@miroslavstastny @fabricteam