-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for checkbox Web Component V3 #28814
Adds tests for checkbox Web Component V3 #28814
Conversation
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report🤖 This report was generated against 8535836fcc2e41c9f4e18df3950d04f1b50d1719 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 8535836fcc2e41c9f4e18df3950d04f1b50d1719 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 003cc95:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at the FASTCheckbox docs and saw this:
* @fires change - Emits a custom change event when the checked state changes
I didn't find any custom events being fired specifically for this in the code. It seems like it might be referring to the native event from the created input in ForAssociatedCheckbox.
I'm wondering if we need to test this. Since it's not something we've custom-coded, I'm not sure if it's necessary or not. But I thought I'd throw the question out there. Thoughts?
New Behavior
Adds tests for checkbox component