Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for checkbox Web Component V3 #28814

Merged

Conversation

procload
Copy link
Contributor

New Behavior

Adds tests for checkbox component

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2023

🕵 fluentui-web-components-v3 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 10, 2023

📊 Bundle size report

🤖 This report was generated against 8535836fcc2e41c9f4e18df3950d04f1b50d1719

@size-auditor
Copy link

size-auditor bot commented Aug 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8535836fcc2e41c9f4e18df3950d04f1b50d1719 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 003cc95:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

Copy link
Contributor

@brianchristopherbrady brianchristopherbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the FASTCheckbox docs and saw this:

* @fires change - Emits a custom change event when the checked state changes

I didn't find any custom events being fired specifically for this in the code. It seems like it might be referring to the native event from the created input in ForAssociatedCheckbox.

I'm wondering if we need to test this. Since it's not something we've custom-coded, I'm not sure if it's necessary or not. But I thought I'd throw the question out there. Thoughts?

@procload procload enabled auto-merge (squash) August 17, 2023 18:25
@procload procload merged commit 75f36ad into microsoft:web-components-v3 Aug 21, 2023
16 of 19 checks passed
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request Apr 30, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 2, 2024
radium-v pushed a commit that referenced this pull request May 3, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 6, 2024
radium-v pushed a commit that referenced this pull request May 8, 2024
radium-v pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants