Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make listeners for scroll passive #28839

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

@layershifter layershifter requested a review from a team as a code owner August 14, 2023 09:50
@github-actions github-actions bot added this to the August Project Cycle Q4 2023 milestone Aug 14, 2023
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 13 13 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 623 629 5000
Button mount 303 315 5000
Field mount 1068 1083 5000
FluentProvider mount 686 672 5000
FluentProviderWithTheme mount 81 83 10
FluentProviderWithTheme virtual-rerender 59 57 10
FluentProviderWithTheme virtual-rerender-with-unmount 72 73 10
InfoButton mount 13 13 5000 Possible regression
MakeStyles mount 861 854 50000
Persona mount 1707 1667 5000
SpinButton mount 1367 1325 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a73281:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-combobox
Combobox (including child components)
86.939 kB
28.239 kB
86.965 kB
28.251 kB
26 B
12 B
react-combobox
Dropdown (including child components)
85.299 kB
27.875 kB
85.325 kB
27.884 kB
26 B
9 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
202.881 kB
57.576 kB
202.907 kB
57.587 kB
26 B
11 B
react-datepicker-compat
DatePicker Compat
206.965 kB
57.361 kB
206.991 kB
57.376 kB
26 B
15 B
react-infobutton
InfoButton
125.088 kB
39.205 kB
125.114 kB
39.214 kB
26 B
9 B
react-infobutton
InfoLabel
128.758 kB
40.384 kB
128.784 kB
40.394 kB
26 B
10 B
react-menu
Menu (including children components)
134.933 kB
41.372 kB
134.959 kB
41.383 kB
26 B
11 B
react-menu
Menu (including selectable components)
137.619 kB
41.867 kB
137.645 kB
41.877 kB
26 B
10 B
react-popover
Popover
114.441 kB
35.891 kB
114.467 kB
35.9 kB
26 B
9 B
react-positioning
usePositioning
25.111 kB
9.1 kB
25.137 kB
9.109 kB
26 B
9 B
react-tooltip
Tooltip
47.78 kB
16.807 kB
47.806 kB
16.816 kB
26 B
9 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
81.7 kB
21.993 kB
react-avatar
Avatar
46.874 kB
14.463 kB
react-avatar
AvatarGroup
15.98 kB
6.393 kB
react-avatar
AvatarGroupItem
61.653 kB
18.876 kB
react-components
react-components: Button, FluentProvider & webLightTheme
66.478 kB
18.477 kB
react-components
react-components: FluentProvider & webLightTheme
37.651 kB
12.343 kB
react-persona
Persona
53.769 kB
16.336 kB
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
react-table
DataGrid
152.634 kB
42.209 kB
react-table
Table (Primitives only)
39.502 kB
12.099 kB
react-table
Table as DataGrid
126.088 kB
33.577 kB
react-table
Table (Selection only)
71.458 kB
18.877 kB
react-table
Table (Sort only)
70.077 kB
18.48 kB
react-tags-preview
InteractionTag
33.653 kB
9.14 kB
react-tags-preview
Tag
25.292 kB
8.36 kB
react-tags-preview
TagGroup
69.523 kB
20.462 kB
react-tree
FlatTree
129.67 kB
37.187 kB
react-tree
PersonaFlatTree
130.693 kB
37.371 kB
react-tree
PersonaTree
127.588 kB
36.264 kB
react-tree
Tree
126.565 kB
36.065 kB
🤖 This report was generated against d1a32c704b6901ceb3f976ad2148d8bbffc7628a

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d1a32c704b6901ceb3f976ad2148d8bbffc7628a (build)

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@layershifter layershifter merged commit 89bd803 into microsoft:master Aug 17, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: event listeners in createPositioningManager should be passive
3 participants