Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffold Nav preview package #28853

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Scaffold Nav preview package #28853

merged 3 commits into from
Aug 15, 2023

Conversation

mltejera
Copy link
Contributor

@mltejera mltejera commented Aug 14, 2023 •
edited
Loading

Result of running yarn create-package and yarn create-component

@mltejera mltejera mentioned this pull request Aug 14, 2023
Closed
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme mount 73 75 10 Possible regression
FluentProviderWithTheme virtual-rerender 74 62 10 Possible regression
InfoButton mount 13 11 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 624 630 5000
Button mount 328 323 5000
Field mount 1101 1065 5000
FluentProvider mount 691 672 5000
FluentProviderWithTheme mount 73 75 10 Possible regression
FluentProviderWithTheme virtual-rerender 74 62 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 74 78 10
InfoButton mount 13 11 5000 Possible regression
MakeStyles mount 870 857 50000
Persona mount 1750 1661 5000
SpinButton mount 1326 1317 5000

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5dfc9b9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 126 110 1.15:1
TreeWith60ListItems.default 93 82 1.13:1
ButtonMinimalPerf.default 90 82 1.1:1
HeaderSlotsPerf.default 473 447 1.06:1
RadioGroupMinimalPerf.default 269 254 1.06:1
ReactionMinimalPerf.default 224 212 1.06:1
ChatDuplicateMessagesPerf.default 155 148 1.05:1
DatepickerMinimalPerf.default 3824 3647 1.05:1
FlexMinimalPerf.default 155 147 1.05:1
LayoutMinimalPerf.default 202 194 1.04:1
ListCommonPerf.default 396 381 1.04:1
PopupMinimalPerf.default 350 341 1.03:1
TreeMinimalPerf.default 479 463 1.03:1
AttachmentMinimalPerf.default 83 81 1.02:1
ButtonOverridesMissPerf.default 658 647 1.02:1
HeaderMinimalPerf.default 208 204 1.02:1
ItemLayoutMinimalPerf.default 745 729 1.02:1
ListNestedPerf.default 325 319 1.02:1
ListWith60ListItems.default 384 376 1.02:1
LoaderMinimalPerf.default 190 186 1.02:1
SegmentMinimalPerf.default 198 194 1.02:1
TableMinimalPerf.default 240 236 1.02:1
VideoMinimalPerf.default 449 442 1.02:1
AnimationMinimalPerf.default 297 293 1.01:1
AttachmentSlotsPerf.default 649 640 1.01:1
DividerMinimalPerf.default 205 202 1.01:1
DropdownManyItemsPerf.default 393 391 1.01:1
EmbedMinimalPerf.default 1887 1862 1.01:1
FormMinimalPerf.default 228 226 1.01:1
GridMinimalPerf.default 187 186 1.01:1
ProviderMergeThemesPerf.default 670 661 1.01:1
SkeletonMinimalPerf.default 195 194 1.01:1
SliderMinimalPerf.default 731 727 1.01:1
TextMinimalPerf.default 190 189 1.01:1
CustomToolbarPrototype.default 1493 1472 1.01:1
CardMinimalPerf.default 303 303 1:1
ChatMinimalPerf.default 433 434 1:1
CheckboxMinimalPerf.default 1156 1161 1:1
DropdownMinimalPerf.default 1426 1423 1:1
ImageMinimalPerf.default 215 216 1:1
InputMinimalPerf.default 533 535 1:1
MenuMinimalPerf.default 502 500 1:1
MenuButtonMinimalPerf.default 957 960 1:1
PortalMinimalPerf.default 83 83 1:1
SplitButtonMinimalPerf.default 2260 2266 1:1
IconMinimalPerf.default 379 380 1:1
TableManyItemsPerf.default 1098 1101 1:1
BoxMinimalPerf.default 191 192 0.99:1
CarouselMinimalPerf.default 262 264 0.99:1
DialogMinimalPerf.default 444 448 0.99:1
RosterPerf.default 1526 1544 0.99:1
StatusMinimalPerf.default 381 386 0.99:1
ToolbarMinimalPerf.default 536 541 0.99:1
AccordionMinimalPerf.default 79 81 0.98:1
AlertMinimalPerf.default 156 160 0.98:1
ListMinimalPerf.default 307 312 0.98:1
ButtonSlotsPerf.default 310 320 0.97:1
ProviderMinimalPerf.default 197 203 0.97:1
TextAreaMinimalPerf.default 279 288 0.97:1
TooltipMinimalPerf.default 1257 1310 0.96:1
RefMinimalPerf.default 105 111 0.95:1
ChatWithPopoverPerf.default 190 202 0.94:1
LabelMinimalPerf.default 216 229 0.94:1

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 510 B
330 B
global-context
createContextSelector		 537 B
342 B
priority-overflow
createOverflowManager		 4.162 kB
1.735 kB
react-accordion
Accordion (including children components)		 88.456 kB
26.845 kB
react-alert
Alert		 81.7 kB
21.993 kB
react-avatar
Avatar		 46.874 kB
14.463 kB
react-avatar
AvatarGroup		 15.98 kB
6.393 kB
react-avatar
AvatarGroupItem		 61.653 kB
18.876 kB
react-badge
Badge		 23.047 kB
7.218 kB
react-badge
CounterBadge		 23.948 kB
7.516 kB
react-badge
PresenceBadge		 22.004 kB
7.831 kB
react-button
Button		 36.942 kB
9.716 kB
react-button
CompoundButton		 44.291 kB
11.196 kB
react-button
MenuButton		 41.328 kB
10.971 kB
react-button
SplitButton		 49.363 kB
12.514 kB
react-button
ToggleButton		 53.988 kB
11.61 kB
react-card
Card - All		 88.199 kB
25.234 kB
react-card
Card		 83.041 kB
23.706 kB
react-card
CardFooter		 9.202 kB
3.903 kB
react-card
CardHeader		 11.454 kB
4.678 kB
react-card
CardPreview		 10.161 kB
4.279 kB
react-checkbox
Checkbox		 32.736 kB
10.614 kB
react-combobox
Combobox (including child components)		 86.939 kB
28.239 kB
react-combobox
Dropdown (including child components)		 85.299 kB
27.875 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 66.478 kB
18.477 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 202.881 kB
57.576 kB
react-components
react-components: FluentProvider & webLightTheme		 37.651 kB
12.343 kB
react-datepicker-compat
DatePicker Compat		 206.965 kB
57.361 kB
react-dialog
Dialog (including children components)		 86.602 kB
26.308 kB
react-divider
Divider		 16.962 kB
6.266 kB
react-field
Field		 18.159 kB
6.953 kB
react-image
Image		 11.893 kB
4.746 kB
react-infobutton
InfoButton		 125.088 kB
39.205 kB
react-infobutton
InfoLabel		 128.758 kB
40.384 kB
react-input
Input		 23.101 kB
7.644 kB
react-label
Label		 10.287 kB
4.281 kB
react-link
Link		 13.119 kB
5.359 kB
react-menu
Menu (including children components)		 134.933 kB
41.372 kB
react-menu
Menu (including selectable components)		 137.619 kB
41.867 kB
react-overflow
hooks only		 12.419 kB
4.687 kB
react-persona
Persona		 53.769 kB
16.336 kB
react-popover
Popover		 114.441 kB
35.891 kB
react-portal
Portal		 12.255 kB
4.504 kB
react-portal-compat
PortalCompatProvider		 6.48 kB
2.203 kB
react-positioning
usePositioning		 25.111 kB
9.1 kB
react-progress
ProgressBar		 13.582 kB
5.447 kB
react-provider
FluentProvider		 18.196 kB
6.769 kB
react-radio
Radio		 26.481 kB
8.57 kB
react-radio
RadioGroup		 11.486 kB
4.794 kB
react-select
Select		 24.463 kB
8.615 kB
react-slider
Slider		 33.998 kB
11.001 kB
react-spinbutton
SpinButton		 32.545 kB
10.172 kB
react-spinner
Spinner		 19.441 kB
6.977 kB
react-switch
Switch		 28.956 kB
9.179 kB
react-table
DataGrid		 152.634 kB
42.209 kB
react-table
Table (Primitives only)		 39.502 kB
12.099 kB
react-table
Table as DataGrid		 126.088 kB
33.577 kB
react-table
Table (Selection only)		 71.458 kB
18.877 kB
react-table
Table (Sort only)		 70.077 kB
18.48 kB
react-tags-preview
InteractionTag		 33.653 kB
9.14 kB
react-tags-preview
Tag		 25.292 kB
8.36 kB
react-tags-preview
TagGroup		 69.523 kB
20.462 kB
react-text
Text - Default		 12.907 kB
5.102 kB
react-text
Text - Wrappers		 16.079 kB
5.411 kB
react-textarea
Textarea		 27.166 kB
9.013 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 34.611 kB
7.295 kB
react-theme
Teams: Light theme		 19.282 kB
5.486 kB
react-toast
Toast (including Toaster)		 87.554 kB
26.007 kB
react-tooltip
Tooltip		 47.78 kB
16.807 kB
react-tree
FlatTree		 129.67 kB
37.187 kB
react-tree
PersonaFlatTree		 130.693 kB
37.371 kB
react-tree
PersonaTree		 127.588 kB
36.264 kB
react-tree
Tree		 126.565 kB
36.065 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 4d79002ac61cda6a17af61bb1a5aa8569dd2977f

@size-auditor
Copy link

size-auditor bot commented Aug 14, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4d79002ac61cda6a17af61bb1a5aa8569dd2977f (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 14, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 660 636 5000
Breadcrumb mount 1708 1703 1000
Checkbox mount 1718 1730 5000
CheckboxBase mount 1525 1487 5000
ChoiceGroup mount 3006 2950 5000
ComboBox mount 644 657 1000
CommandBar mount 6437 6398 1000
ContextualMenu mount 14575 14684 1000
DefaultButton mount 750 750 5000
DetailsRow mount 2196 2232 5000
DetailsRowFast mount 2220 2266 5000
DetailsRowNoStyles mount 2037 2034 5000
Dialog mount 2802 2709 1000
DocumentCardTitle mount 235 230 1000
Dropdown mount 2015 2037 5000
FocusTrapZone mount 1154 1136 5000
FocusZone mount 1098 1073 5000
GroupedList mount 42000 42202 2
GroupedList virtual-rerender 20340 20230 2
GroupedList virtual-rerender-with-unmount 52018 51891 2
GroupedListV2 mount 229 236 2
GroupedListV2 virtual-rerender 206 219 2
GroupedListV2 virtual-rerender-with-unmount 233 226 2
IconButton mount 1091 1097 5000
Label mount 351 338 5000
Layer mount 2757 2780 5000
Link mount 387 397 5000
MenuButton mount 979 944 5000
MessageBar mount 22012 21912 5000
Nav mount 2022 1988 1000
OverflowSet mount 806 805 5000
Panel mount 1839 1836 1000
Persona mount 750 750 1000
Pivot mount 896 877 1000
PrimaryButton mount 871 864 5000
Rating mount 4613 4618 5000
SearchBox mount 928 942 5000
Shimmer mount 1921 1915 5000
Slider mount 1326 1288 5000
SpinButton mount 2916 2915 5000
Spinner mount 384 382 5000
SplitButton mount 1833 1823 5000
Stack mount 416 416 5000
StackWithIntrinsicChildren mount 871 872 5000
StackWithTextChildren mount 2647 2610 5000
SwatchColorPicker mount 6164 6138 5000
TagPicker mount 1463 1410 5000
Text mount 376 382 5000
TextField mount 976 949 5000
ThemeProvider mount 840 840 5000
ThemeProvider virtual-rerender 607 586 5000
ThemeProvider virtual-rerender-with-unmount 1306 1310 5000
Toggle mount 596 626 5000
buttonNative mount 204 194 5000

behowell
behowell approved these changes Aug 14, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
marcosmoura
marcosmoura approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@marcosmoura marcosmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for files owned by @microsoft/fluentui-react-build

@mltejera mltejera merged commit 62e955c into master Aug 15, 2023
25 checks passed
@khmakoto khmakoto deleted the user/matejera/scaffold-nav-2 branch August 15, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

@behowell behowell behowell approved these changes

@JustSlone JustSlone Awaiting requested review from JustSlone JustSlone is a code owner

@jurokapsiar jurokapsiar Awaiting requested review from jurokapsiar jurokapsiar is a code owner

@tudorpopams tudorpopams Awaiting requested review from tudorpopams tudorpopams is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mltejera @fabricteam @marcosmoura @behowell