menu list unit tests #28857
Merged
menu list unit tests #28857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erbrady/fluentui-fork into web-components-v3
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report🤖 This report was generated against c7b318221b2bd34b3b60c61c84859e9bc861b0a2 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c7b318221b2bd34b3b60c61c84859e9bc861b0a2 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 400c424:
|
halerankin
reviewed
Aug 15, 2023
| await expect(menuItems.nth(3)).toBeFocused(); | ||
| }); | ||
|
|
||
| test('should close the menu when pressing the escape key', async () => { |
There was a problem hiding this comment.
Looks like this is testing to see if the focus returns to the parent item after the Esc key is pressed. I would reword the test to make your assertion clearer.
halerankin
reviewed
Aug 15, 2023
| await root.evaluate(node => { | ||
| node.innerHTML = /* html */ ` | ||
| <fluent-menu-list> | ||
| <fluent-menu-item role="menuitemcheckbox"></fluent-menu-item> |
There was a problem hiding this comment.
role should be: menuitemradio
There was a problem hiding this comment.
good catch!
miroslavstastny
approved these changes
Aug 23, 2023
miroslavstastny
merged commit be3c3cb
into
microsoft:web-components-v3
22 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* radio init * styles radio * reverts branch * input spec init * cleans up spec * formatting * updates component name to text input * updates component name in spec * reverts dead file * adds menulist unit tests * menu-list tests: updates test names, fixes role attribute in radio test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds MenuList playwright tests