chore(divider): Add screenshot tests #28860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
fabricteam
reviewed
Aug 15, 2023
| @@ -0,0 +1,74 @@ | |||
| import * as React from 'react'; | |||
There was a problem hiding this comment.
🕵 fluentui-web-components-v3 Open the Visual Regressions report to inspect the affected screenshots
Divider 20 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Divider.Align Content Center.normal.chromium.png | 0 | Added |
| Divider.Align Content End - RTL.normal.chromium.png | 0 | Added |
| Divider.Align Content End.normal.chromium.png | 0 | Added |
| Divider.Align Content Start - RTL.normal.chromium.png | 0 | Added |
| Divider.Align Content Start.normal.chromium.png | 0 | Added |
| Divider.Appearance Brand - Dark Mode.normal.chromium.png | 0 | Added |
| Divider.Appearance Brand.normal.chromium.png | 0 | Added |
| Divider.Appearance Default - Dark Mode.normal.chromium.png | 0 | Added |
| Divider.Appearance Default.normal.chromium.png | 0 | Added |
| Divider.Appearance Strong - Dark Mode.normal.chromium.png | 0 | Added |
| Divider.Appearance Strong.normal.chromium.png | 0 | Added |
| Divider.Appearance Subtle - Dark Mode.normal.chromium.png | 0 | Added |
| Divider.Appearance Subtle.normal.chromium.png | 0 | Added |
| Divider.Default - Dark Mode.normal.chromium.png | 0 | Added |
| Divider.Default.normal.chromium.png | 0 | Added |
| Divider.Inset.normal.chromium.png | 0 | Added |
| Divider.Vertical With Svg.normal.chromium.png | 0 | Added |
| Divider.Vertical.normal.chromium.png | 0 | Added |
| Divider.With Svg - RTL.normal.chromium.png | 0 | Added |
| Divider.With Svg.normal.chromium.png | 0 | Added |
📊 Bundle size report🤖 This report was generated against 4cdb75f551ad5920e5184b6bdfd7585d64026c18 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 46f65d10bedb042fd79a23c537bf7856fb38b497 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 311439c:
|
miroslavstastny
merged commit a593dae
into
microsoft:web-components-v3
22 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* chore(divider): Add screenshot tests * divider with icon in RTL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add screenshot tests for
fluent-divider