Adds unit tests for CounterBadge #28867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
procload
requested review from
levithomason,
miroslavstastny,
brianchristopherbrady and
chrisdholt
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
📊 Bundle size report🤖 This report was generated against 2c97f929d3fd505f65f4094a4f45fbc008eb2b9d |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2c97f929d3fd505f65f4094a4f45fbc008eb2b9d (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8aca87f:
|
halerankin
approved these changes
Aug 15, 2023
brianchristopherbrady
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Multiple flaky tests are reported:
8 flaky
[chromium] › src/counter-badge/counter-badge.spec.ts:73:3 › CounterBadge component › should show 0 when showZero is set programmatically
[chromium] › src/counter-badge/counter-badge.spec.ts:89:3 › CounterBadge component › should not show 0 when showZero is set programmatically
[chromium] › src/counter-badge/counter-badge.spec.ts:121:3 › CounterBadge component › should show and hide dot programmatically
[firefox] › src/counter-badge/counter-badge.spec.ts:73:3 › CounterBadge component › should show 0 when showZero is set programmatically
[firefox] › src/counter-badge/counter-badge.spec.ts:89:3 › CounterBadge component › should not show 0 when showZero is set programmatically
[firefox] › src/counter-badge/counter-badge.spec.ts:121:3 › CounterBadge component › should show and hide dot programmatically
[webkit] › src/counter-badge/counter-badge.spec.ts:73:3 › CounterBadge component › should show 0 when showZero is set programmatically
[webkit] › src/counter-badge/counter-badge.spec.ts:89:3 › CounterBadge component › should not show 0 when showZero is set programmatically
…procload/counterBadgeTests
…procload/counterBadgeTests
| @@ -96,6 +94,7 @@ test.describe('CounterBadge component', () => { | |||
|
|
|||
| const shadowContent = await page.evaluate(() => { | |||
| const element = document.querySelector('fluent-counter-badge'); | |||
| console.log(element); | |||
There was a problem hiding this comment.
remove the console.log()
|
I still see flaky tests: Edit: another run: |
|
Still red: |
| @@ -26,7 +26,7 @@ module.exports = /** @type {Omit<import('../../../.storybook/main').StorybookCon | |||
| backgrounds: false, | |||
| viewport: false, | |||
| toolbars: false, | |||
| actions: false, | |||
There was a problem hiding this comment.
Is this intentional or just a debugging left over?
miroslavstastny
approved these changes
Aug 24, 2023
miroslavstastny
merged commit e414e26
into
microsoft:web-components-v3
24 checks passed
chrisdholt
pushed a commit
that referenced
this pull request
Apr 29, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* Adds tests for counterBadge * Removes tests for slotted icon content * Adds tests to verify if showZero and dot are able to be set programmatically * Fixes linting errors * Changes beforeAll to beforeEach to fix flaky tests * Removes .only * Tries to unflake * Adds fixes for flaky tests * Updates tests without shadowContent query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Adds tests for CounterBadge