chore(react-nav-preview): migrates to use new slot API #28917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 768de13c5e30222f64b2cc453bc4b134a6e90712 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 01f21f4:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 768de13c5e30222f64b2cc453bc4b134a6e90712 (build) |
khmakoto
approved these changes
Aug 21, 2023
bsunderhus
deleted the
react-nav-preview/chore--migrates-to-use-new-slot-API
branch
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 22, 2023
* master: chore: updates generator to use new slot API (microsoft#28916) chore: bumps version of esbuild-loader to v3.2.0 (microsoft#28878) chore(react-nav-preview): migrates to use new slot API (microsoft#28917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
Seems like this package has been scaffolded after the new slot API has been implemented, but before updating the scaffolding tools 🙈 (#28916)
Related Issue(s)