Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Keytips: Align keytipData with visible instance for dupes" #28977

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Revert "Keytips: Align keytipData with visible instance for dupes" #28977

merged 2 commits into from
Aug 24, 2023

Conversation

makopch-ms
Copy link
Contributor

Reverts #28522

This is causing perf regressions with the querySelectorAll in Office online apps.

@makopch-ms makopch-ms requested review from a team as code owners August 24, 2023 18:58
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 24, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 218b153:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 7e494ac4414be5eac624a69bfecd5a84c26227e4

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

🕵 fluentuiv8 No visual regressions between this PR and main

@size-auditor
Copy link

size-auditor bot commented Aug 24, 2023 •
edited
Loading

Asset size changes

Project Bundle Baseline Size New Size Difference
office-ui-fabric-react fluentui-react-Keytips 101.087 kB 100.981 kB BelowBaseline     -106 bytes
office-ui-fabric-react fluentui-react-KeytipLayer 98.335 kB 98.227 kB BelowBaseline     -108 bytes

ExceedsTolerance Over Tolerance (1024 B) ExceedsBaseline Over Baseline BelowBaseline Below Baseline New New Deleted  Removed 1 kB = 1000 B

Baseline commit: 7e494ac4414be5eac624a69bfecd5a84c26227e4 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Aug 24, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 635 650 5000
Breadcrumb mount 1691 1682 1000
Checkbox mount 1715 1759 5000
CheckboxBase mount 1494 1479 5000
ChoiceGroup mount 2947 2920 5000
ComboBox mount 658 659 1000
CommandBar mount 6295 6254 1000
ContextualMenu mount 14533 14515 1000
DefaultButton mount 779 736 5000
DetailsRow mount 2207 2184 5000
DetailsRowFast mount 2218 2180 5000
DetailsRowNoStyles mount 1997 1980 5000
Dialog mount 2606 2632 1000
DocumentCardTitle mount 225 228 1000
Dropdown mount 1989 1996 5000
FocusTrapZone mount 1120 1135 5000
FocusZone mount 1049 1087 5000
GroupedList mount 41717 41686 2
GroupedList virtual-rerender 19966 20071 2
GroupedList virtual-rerender-with-unmount 53322 51395 2
GroupedListV2 mount 224 233 2
GroupedListV2 virtual-rerender 202 212 2
GroupedListV2 virtual-rerender-with-unmount 234 228 2
IconButton mount 1071 1091 5000
Label mount 332 337 5000
Layer mount 2696 2744 5000
Link mount 392 396 5000
MenuButton mount 952 951 5000
MessageBar mount 21598 21554 5000
Nav mount 1957 1913 1000
OverflowSet mount 789 787 5000
Panel mount 1773 1800 1000
Persona mount 731 751 1000
Pivot mount 868 882 1000
PrimaryButton mount 853 851 5000
Rating mount 4559 4568 5000
SearchBox mount 916 933 5000
Shimmer mount 1854 1857 5000
Slider mount 1348 1313 5000
SpinButton mount 2871 2864 5000
Spinner mount 388 391 5000
SplitButton mount 1817 1795 5000
Stack mount 402 414 5000
StackWithIntrinsicChildren mount 869 856 5000
StackWithTextChildren mount 2628 2581 5000
SwatchColorPicker mount 6178 6142 5000
TagPicker mount 1470 1533 5000
Text mount 372 370 5000
TextField mount 934 941 5000
ThemeProvider mount 832 835 5000
ThemeProvider virtual-rerender 583 586 5000
ThemeProvider virtual-rerender-with-unmount 1256 1288 5000
Toggle mount 634 616 5000
buttonNative mount 197 190 5000

@khmakoto khmakoto enabled auto-merge (squash) August 24, 2023 21:23
@khmakoto khmakoto merged commit 7f699be into microsoft:master Aug 24, 2023
21 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/add-motion-to-drawer
8976c76 
* master: (23 commits)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/ignore-motion-when-reduced-motion-is-on
b8f6e51 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/drawer-motion
7606af3 
* master: (24 commits)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  Focus indicator bug in bar charts (microsoft#28414)
  Pie chart focus spacing (microsoft#28504)
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Aug 28, 2023
@marcosmoura
Merge branch 'master' into feat/react-toast-use-motion
0437940 
* master: (26 commits)
  chore: Make triage bot add needs triage label to new issues (microsoft#28994)
  fix(react-tags-preview): use regular icon for dismiss (microsoft#28958)
  feat(react-motion): add useMotion hook (microsoft#28699)
  feat: add closeOnIframeFocus prop to Popover (microsoft#28881)
  chore: updates .devcontainer to follow new format (microsoft#28990)
  Line Chart and Area Chart - Component tests (microsoft#28235)
  applying package updates
  28576 small button is using 3px border radius (microsoft#28589)
  In PeoplePicker, we can now use arrow keys to move cursor around microsoft#28655 (microsoft#28975)
  chore: Migrate bot config to yml (microsoft#28981)
  fix(react-card): CardHeader grid layout ignoring line-height of content (microsoft#28968)
  fix(react-tags-preview): tag with secondary text has no top border under windows high contrast (microsoft#28963)
  applying package updates
  feat(Stack): Add deprecated flag to render null when receiving a falsy value (microsoft#28978)
  feat(react-infobutton): Add inline prop to InfoButton and make it inline by default (microsoft#28605)
  fix(Dialog): Add displayName for dialog footer and content (microsoft#28939)
  Revert "Keytips: Align keytipData with visible instance for dupes" (microsoft#28977)
  Vertical stacked bar chart - Component tests (microsoft#28594)
  docs: update drawer spec to be inline with changes to component (microsoft#28934)
  Table/DataGrid: fix visuals for overflow (microsoft#28940)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jspurlin jspurlin jspurlin approved these changes

@khmakoto khmakoto khmakoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@makopch-ms @fabricteam @jspurlin @khmakoto