bugfix(react-utilities): omit IntrinsicElement props from ComponentProps that would collide with slot names #29865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Component: AvatarGroup
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender | 62 | 64 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 631 | 654 | 5000 | |
| Button | mount | 311 | 307 | 5000 | |
| Field | mount | 1132 | 1124 | 5000 | |
| FluentProvider | mount | 708 | 707 | 5000 | |
| FluentProviderWithTheme | mount | 84 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 62 | 64 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 76 | 10 | |
| MakeStyles | mount | 831 | 867 | 50000 | |
| Persona | mount | 1724 | 1733 | 5000 | |
| SpinButton | mount | 1339 | 1381 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6d54617:
|
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-utilities/bugfix--omit-IntrinsicElement-props-from-ComponentProps-that-would-collide-with-slot-names
branch
2 times, most recently
from
955b723
to
9b93575
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d8321c5e8191f94e9413aee0e800f96d3de8e311 (build) |
miroslavstastny
approved these changes
Nov 20, 2023
behowell
reviewed
Dec 1, 2023
layershifter
approved these changes
Jan 8, 2024
bsunderhus
force-pushed
the
react-utilities/bugfix--omit-IntrinsicElement-props-from-ComponentProps-that-would-collide-with-slot-names
branch
from
e0cfcd3
to
fed2542
Compare
github-actions
bot
modified the milestones:
November Project Cycle Q1 2023,
January Project Cycle Q1 2024
bsunderhus
force-pushed
the
react-utilities/bugfix--omit-IntrinsicElement-props-from-ComponentProps-that-would-collide-with-slot-names
branch
from
fed2542
to
6d54617
Compare
behowell
approved these changes
Jan 12, 2024
bsunderhus
deleted the
react-utilities/bugfix--omit-IntrinsicElement-props-from-ComponentProps-that-would-collide-with-slot-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
As #29596 describes, some properties that were declared by
@types/reactwere clashing with slot names, most common case would be the one involving thecontentslot.New Behavior
@types/reactin favor of the slot names providedRelated Issue(s)
contentproperty is name clashing between react types and some v9 components #29596