Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unify v9 babel preset in all packages #31088

Merged
merged 5 commits into from
Apr 19, 2024
Merged

feat: unify v9 babel preset in all packages #31088

merged 5 commits into from
Apr 19, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Apr 17, 2024 •
edited
Loading

Previous Behavior

react-provider uses different babel setup for griffel processing

New Behavior

react-provider uses same babel setup for griffel.

Related Issue(s)

  • Fixes #

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Apr 17, 2024
@Hotell Hotell marked this pull request as ready for review April 17, 2024 15:09
@Hotell Hotell requested review from a team as code owners April 17, 2024 15:09
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024 •
edited
Loading

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 638 630 5000
Button mount 309 308 5000
Field mount 1117 1141 5000
FluentProvider mount 703 709 5000
FluentProviderWithTheme mount 85 88 10
FluentProviderWithTheme virtual-rerender 33 33 10
FluentProviderWithTheme virtual-rerender-with-unmount 66 77 10
MakeStyles mount 833 865 50000
Persona mount 1740 1717 5000
SpinButton mount 1360 1392 5000
SwatchPicker mount 1517 1479 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LayoutMinimalPerf.default 205 183 1.12:1
PortalMinimalPerf.default 91 84 1.08:1
AvatarMinimalPerf.default 110 103 1.07:1
ButtonSlotsPerf.default 324 302 1.07:1
HeaderSlotsPerf.default 496 464 1.07:1
RefMinimalPerf.default 112 105 1.07:1
TableMinimalPerf.default 249 233 1.07:1
ChatWithPopoverPerf.default 205 194 1.06:1
FlexMinimalPerf.default 163 154 1.06:1
RadioGroupMinimalPerf.default 269 256 1.05:1
StatusMinimalPerf.default 402 382 1.05:1
CardMinimalPerf.default 315 302 1.04:1
CarouselMinimalPerf.default 261 252 1.04:1
ImageMinimalPerf.default 226 217 1.04:1
ListMinimalPerf.default 315 302 1.04:1
TreeMinimalPerf.default 503 484 1.04:1
VideoMinimalPerf.default 439 424 1.04:1
AttachmentMinimalPerf.default 81 79 1.03:1
BoxMinimalPerf.default 198 192 1.03:1
DialogMinimalPerf.default 447 433 1.03:1
GridMinimalPerf.default 191 185 1.03:1
SegmentMinimalPerf.default 202 197 1.03:1
SliderMinimalPerf.default 763 743 1.03:1
SplitButtonMinimalPerf.default 2338 2261 1.03:1
ReactionMinimalPerf.default 214 210 1.02:1
TextAreaMinimalPerf.default 294 287 1.02:1
ToolbarMinimalPerf.default 545 533 1.02:1
AlertMinimalPerf.default 167 166 1.01:1
AttachmentSlotsPerf.default 623 616 1.01:1
DatepickerMinimalPerf.default 3595 3560 1.01:1
FormMinimalPerf.default 224 221 1.01:1
ProviderMinimalPerf.default 204 202 1.01:1
AccordionMinimalPerf.default 82 82 1:1
DividerMinimalPerf.default 203 202 1:1
DropdownMinimalPerf.default 1420 1423 1:1
LabelMinimalPerf.default 213 214 1:1
ListNestedPerf.default 333 332 1:1
PopupMinimalPerf.default 342 343 1:1
TableManyItemsPerf.default 1105 1102 1:1
CustomToolbarPrototype.default 1469 1467 1:1
TreeWith60ListItems.default 86 86 1:1
ButtonMinimalPerf.default 87 88 0.99:1
ButtonOverridesMissPerf.default 651 655 0.99:1
ChatDuplicateMessagesPerf.default 150 152 0.99:1
CheckboxMinimalPerf.default 1126 1134 0.99:1
HeaderMinimalPerf.default 209 212 0.99:1
ItemLayoutMinimalPerf.default 696 702 0.99:1
ListWith60ListItems.default 368 371 0.99:1
IconMinimalPerf.default 383 388 0.99:1
AnimationMinimalPerf.default 292 298 0.98:1
EmbedMinimalPerf.default 1862 1901 0.98:1
ListCommonPerf.default 398 406 0.98:1
MenuMinimalPerf.default 496 504 0.98:1
MenuButtonMinimalPerf.default 951 968 0.98:1
ProviderMergeThemesPerf.default 634 646 0.98:1
SkeletonMinimalPerf.default 203 207 0.98:1
TextMinimalPerf.default 194 197 0.98:1
ChatMinimalPerf.default 434 446 0.97:1
InputMinimalPerf.default 539 564 0.96:1
LoaderMinimalPerf.default 189 196 0.96:1
TooltipMinimalPerf.default 1218 1268 0.96:1
DropdownManyItemsPerf.default 389 408 0.95:1
RosterPerf.default 1518 1600 0.95:1

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 17, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024 •
edited
Loading

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell enabled auto-merge (squash) April 17, 2024 19:04
@Hotell Hotell merged commit 6c94822 into microsoft:master Apr 19, 2024
20 checks passed
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
@marcosmoura
Merge branch 'master' into feat/react-drawer/move-scroll-to-contex
456e2bf 
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
@marcosmoura
Merge branch 'master' into feat/react-drawer/move-scroll-to-context
033678b 
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request Jun 14, 2024
@Hotell @miroslavstastny
feat: unify v9 babel preset in all packages (microsoft#31088)
d9b343b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System Area: JS Styling Fluent UI react-components (v9)
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hotell @fabricteam @layershifter @tudorpopams