Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-swatch-picker): fixes after bug bash #31097

Merged

Conversation

ValentinaKozlova
Copy link
Contributor

Bug bash changes:

  • Changed extraSmall to extra-small to be consistent with other components
  • Removed empty best practices, it'll be on Fluent website
  • moved styles of spacing to styling file
  • added opportunity to reset example for EmptySwatch

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-swatch-picker-preview
@fluentui/react-swatch-picker-preview - package
108.469 kB
30.284 kB
108.416 kB
30.25 kB
-53 B
-34 B

🤖 This report was generated against 6c94822d2877f8ca31b2fbdf7b63ceaf42815397

Copy link

codesandbox-ci bot commented Apr 17, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 17, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

@ValentinaKozlova ValentinaKozlova marked this pull request as ready for review April 18, 2024 15:53
@ValentinaKozlova ValentinaKozlova requested review from a team as code owners April 18, 2024 15:53
…5-a4dd-6aa211c022b9.json

Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
@ValentinaKozlova ValentinaKozlova enabled auto-merge (squash) April 19, 2024 12:56
@ValentinaKozlova ValentinaKozlova merged commit ab8aee0 into microsoft:master Apr 19, 2024
16 of 18 checks passed
@ValentinaKozlova ValentinaKozlova deleted the fix/swatch-picker-bug-bash branch April 19, 2024 13:53
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 23, 2024
* master: (416 commits)
  fix: remove relative imports within stories which are invalid for creating 'show docs' and circular dep imports from cypress files (microsoft#31087)
  Fix overlapping bars on continuous axes (microsoft#31035)
  feat(scripts-tasks): implement ~36% faster type-check task (microsoft#31116)
  feat(workspace-plugin): implement split-library-in-two migration generator (microsoft#31086)
  applying package updates
  Sankey diagram: Support number formatting (microsoft#31113)
  Fix wrong position of hover callout in case of single data AreaChart (microsoft#30256)
  Combobox filtering bug fix (microsoft#31141)
  chore(react-tag-picker): adds text elliptical clipping example (microsoft#31114)
  docs: command cheat sheet (microsoft#30685)
  chore: refactor tests for createPresenceComponent() (microsoft#31137)
  Stable Release: TeachingPopover (microsoft#31112)
  applying package updates
  fix: SpinButton buttons now show correct visuals at bounds (microsoft#31126)
  feat: add accessibility docs to Link about color/underlines (microsoft#31121)
  fix: Table and DataGrid should not remove cells from the accessibility tree (microsoft#31068)
  Add shadow DOM support to `@fluentui/react` (Fluent v8) (microsoft#30689)
  fix(react-swatch-picker): fixes after bug bash (microsoft#31097)
  feat: unify v9 babel preset in all packages (microsoft#31088)
  applying package updates
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants