-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(OverflowItem): properly propagate refs to child elements #31347
Merged
layershifter
merged 2 commits into
microsoft:master
from
layershifter:fix/overflow-trigger
May 14, 2024
Merged
fix(OverflowItem): properly propagate refs to child elements #31347
layershifter
merged 2 commits into
microsoft:master
from
layershifter:fix/overflow-trigger
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 631 | 623 | 5000 | |
Button | mount | 307 | 304 | 5000 | |
Field | mount | 1144 | 1104 | 5000 | |
FluentProvider | mount | 698 | 715 | 5000 | |
FluentProviderWithTheme | mount | 80 | 82 | 10 | |
FluentProviderWithTheme | virtual-rerender | 37 | 41 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 73 | 79 | 10 | |
MakeStyles | mount | 857 | 858 | 50000 | |
Persona | mount | 1765 | 1750 | 5000 | |
SpinButton | mount | 1395 | 1405 | 5000 | |
SwatchPicker | mount | 1520 | 1555 | 5000 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
📊 Bundle size report
Unchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
layershifter
force-pushed
the
fix/overflow-trigger
branch
from
May 13, 2024 11:34
96d3d5d
to
df20b12
Compare
george-cz
approved these changes
May 13, 2024
packages/react-components/react-overflow/src/components/OverflowItem/OverflowItem.test.tsx
Show resolved
Hide resolved
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
*Trigger
components are used (adds.isFluentTriggerComponent
)child.ref
)Related Issue(s)
Fixes #31346