-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate .shorthands() [teams-prg] #31432
Merged
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/migrate-shorthands-prg
May 22, 2024
Merged
chore: migrate .shorthands() [teams-prg] #31432
layershifter
merged 1 commit into
microsoft:master
from
layershifter:chore/migrate-shorthands-prg
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/migrate-shorthands-prg
branch
from
May 21, 2024 11:04
67e5617
to
ee98a69
Compare
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
May 21, 2024
...s/react-components/react-aria/stories/AriaLiveAnnouncer/AriaLiveAnnouncerDefault.stories.tsx
Show resolved
Hide resolved
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 28 | 36 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 644 | 609 | 5000 | |
Button | mount | 307 | 312 | 5000 | |
Field | mount | 1133 | 1144 | 5000 | |
FluentProvider | mount | 711 | 711 | 5000 | |
FluentProviderWithTheme | mount | 91 | 90 | 10 | |
FluentProviderWithTheme | virtual-rerender | 28 | 36 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 84 | 76 | 10 | |
MakeStyles | mount | 849 | 856 | 50000 | |
Persona | mount | 1776 | 1720 | 5000 | |
SpinButton | mount | 1391 | 1396 | 5000 | |
SwatchPicker | mount | 1585 | 1587 | 5000 |
layershifter
force-pushed
the
chore/migrate-shorthands-prg
branch
7 times, most recently
from
May 21, 2024 14:04
322a629
to
14a0e46
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
layershifter
force-pushed
the
chore/migrate-shorthands-prg
branch
4 times, most recently
from
May 22, 2024 13:15
6b5b666
to
d00c916
Compare
layershifter
requested review from
a team,
marcosmoura,
chpalac,
ling1726 and
smhigley
as code owners
May 22, 2024 14:32
ling1726
approved these changes
May 22, 2024
layershifter
force-pushed
the
chore/migrate-shorthands-prg
branch
from
May 22, 2024 15:18
d00c916
to
d7d7cf5
Compare
fabricteam
reviewed
May 22, 2024
change/@fluentui-react-combobox-4a7ed138-43ff-437b-9c1e-24fa4586982a.json
Show resolved
Hide resolved
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Components owned by
teams-prg
useshorthands.*()
.New Behavior
Components owned by
teams-prg
do useshorthands.*()
, bundle size is decreased 👍Related Issue(s)
Fixes #31318.